You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/12/06 07:51:21 UTC
[kudu-CR] fs: rename PathInstance-related things
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14862
Change subject: fs: rename PathInstance-related things
......................................................................
fs: rename PathInstance-related things
I'm expecting the directory management code to be reused for WAL
directories, and I've sometimes found it mildly annoying that we have
different nomenclature for path instances, directories, and block
managers in the same area (mostly in the PathInstances). So thought I'd
rename some things now to make some things more straight-forward:
* PathInstanceMetadataFile -> DirInstanceMetadataFile
* PathInstanceMetadataPB -> DirInstanceMetadataPB
* PathSetPB -> DirSetPB
* block_manager_type -> dir_type (in the context of instance files only)
Along the way, I modernized our usage of the DataDir threadpool when
Open()ing the DataDirManager.
Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
---
M src/kudu/fs/CMakeLists.txt
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
R src/kudu/fs/dir_util-test.cc
R src/kudu/fs/dir_util.cc
R src/kudu/fs/dir_util.h
M src/kudu/fs/error_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/log_block_manager.cc
12 files changed, 120 insertions(+), 119 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/14862/1
--
To view, visit http://gerrit.cloudera.org:8080/14862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
Gerrit-Change-Number: 14862
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] fs: rename PathInstance-related things
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14862
to look at the new patch set (#2).
Change subject: fs: rename PathInstance-related things
......................................................................
fs: rename PathInstance-related things
I'm expecting the directory management code to be reused for WAL
directories, and I've sometimes found it mildly annoying that we have
different nomenclature for path instances, directories, and block
managers in the same area (mostly in the PathInstances). So thought I'd
rename some things now to make some things more straight-forward:
* PathInstanceMetadataFile -> DirInstanceMetadataFile
* PathInstanceMetadataPB -> DirInstanceMetadataPB
* PathSetPB -> DirSetPB
* block_manager_type -> dir_type (in the context of instance files only)
* block_manager_util -> dir_util
Along the way, I modernized our usage of the DataDir threadpool when
calling DataDirManager::Open().
Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
---
M src/kudu/fs/CMakeLists.txt
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
R src/kudu/fs/dir_util-test.cc
R src/kudu/fs/dir_util.cc
R src/kudu/fs/dir_util.h
M src/kudu/fs/error_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
13 files changed, 123 insertions(+), 127 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/14862/2
--
To view, visit http://gerrit.cloudera.org:8080/14862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
Gerrit-Change-Number: 14862
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] fs: rename PathInstance-related things
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14862
to look at the new patch set (#3).
Change subject: fs: rename PathInstance-related things
......................................................................
fs: rename PathInstance-related things
I'm expecting the directory management code to be reused for WAL
directories, and I've sometimes found it mildly annoying that we have
different nomenclature for path instances, directories, and block
managers in the same area (mostly in the PathInstances). So thought I'd
rename some things now to make some things more straight-forward:
* PathInstanceMetadataFile -> DirInstanceMetadataFile
* PathInstanceMetadataPB -> DirInstanceMetadataPB
* PathSetPB -> DirSetPB
* block_manager_type -> dir_type (in the context of instance files only)
* block_manager_util -> dir_util
Along the way, I modernized our usage of the DataDir threadpool when
calling DataDirManager::Open().
Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
---
M src/kudu/fs/CMakeLists.txt
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
R src/kudu/fs/dir_util-test.cc
R src/kudu/fs/dir_util.cc
R src/kudu/fs/dir_util.h
M src/kudu/fs/error_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
13 files changed, 123 insertions(+), 129 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/14862/3
--
To view, visit http://gerrit.cloudera.org:8080/14862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
Gerrit-Change-Number: 14862
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] fs: rename PathInstance-related things
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14862 )
Change subject: fs: rename PathInstance-related things
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
Gerrit-Change-Number: 14862
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 06 Dec 2019 19:19:10 +0000
Gerrit-HasComments: No
[kudu-CR] fs: rename PathInstance-related things
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14862 )
Change subject: fs: rename PathInstance-related things
......................................................................
fs: rename PathInstance-related things
I'm expecting the directory management code to be reused for WAL
directories, and I've sometimes found it mildly annoying that we have
different nomenclature for path instances, directories, and block
managers in the same area (mostly in the PathInstances). So thought I'd
rename some things now to make some things more straight-forward:
* PathInstanceMetadataFile -> DirInstanceMetadataFile
* PathInstanceMetadataPB -> DirInstanceMetadataPB
* PathSetPB -> DirSetPB
* block_manager_type -> dir_type (in the context of instance files only)
* block_manager_util -> dir_util
Along the way, I modernized our usage of the DataDir threadpool when
calling DataDirManager::Open().
Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
Reviewed-on: http://gerrit.cloudera.org:8080/14862
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/fs/CMakeLists.txt
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/data_dirs.h
R src/kudu/fs/dir_util-test.cc
R src/kudu/fs/dir_util.cc
R src/kudu/fs/dir_util.h
M src/kudu/fs/error_manager.h
M src/kudu/fs/file_block_manager.cc
M src/kudu/fs/fs.proto
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/fs/log_block_manager.h
13 files changed, 123 insertions(+), 129 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89049fafe149d535d584e7d4cd2497c298c16043
Gerrit-Change-Number: 14862
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)