Re: [PR] Use timeout when inntializing _timeout_sec of TaskStateTrigger [airflow]

["utkarsharma2 (via GitHub)" <gi...@apache.org>]

utkarsharma2 commented on code in PR #34715:
URL: https://github.com/apache/airflow/pull/34715#discussion_r1343582659


##########
airflow/sensors/external_task.py:
##########
@@ -341,6 +341,7 @@ def execute(self, context: Context) -> None:
                     states=self.allowed_states,
                     trigger_start_time=utcnow(),
                     poll_interval=self.poll_interval,
+                    timeout=self.timeout,

Review Comment:
   @Xiroo  `self.timeout` is getting initialized from `conf.getfloat("sensors", "default_timeout"),` in base sensor and it's default value is `Sensor default timeout, 7 days by default (7 * 24 * 60 * 60).` I don't know what should be a meaningful default but this will be a drastic change for people using the existing default value of 60 sec kind of breaking change IMO.
   
   cc: @uranusjr @hussein-awala 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org