You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/08/08 23:48:55 UTC
Review Request 24509: Refactored credentials and ACLs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24509/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/defer.hpp dc2ec3bb4cc76bbef0dba2a4d7dd804f9ba1fa4a
3rdparty/libprocess/include/process/deferred.hpp 0552fb51f310b2ee0db7fbe31eabc6d161d1506e
include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83
src/authorizer/authorizer.hpp b7f11191aea5deeea2403a6dd900eec9cc77ad56
src/authorizer/authorizer.cpp 40a14becde44324bddefef1c6fe61b228ca505d3
src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0
src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b
src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797
src/master/master.cpp 56306809096db36bc1884c87957a7b2c76610a93
src/sasl/authenticator.hpp aa222d30eaf738d9ed1d46a6689e39b2283ec1c8
src/tests/authorization_tests.cpp 611f3713c0bf4dee631a935f08c9edf2776ab3ad
src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596
src/tests/script.cpp 31294790f7146e5867067a0d45bd4d0e7d0885cd
Diff: https://reviews.apache.org/r/24509/diff/
Testing
-------
make check (WIP)
Thanks,
Benjamin Hindman
Re: Review Request 24509: Refactored credentials and ACLs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24509/#review50093
-----------------------------------------------------------
Ship it!
Fixed some build errors, added tests and updated docs/flags.
I'll get this committed.
- Vinod Kone
On Aug. 8, 2014, 9:48 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24509/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 9:48 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/defer.hpp dc2ec3bb4cc76bbef0dba2a4d7dd804f9ba1fa4a
> 3rdparty/libprocess/include/process/deferred.hpp 0552fb51f310b2ee0db7fbe31eabc6d161d1506e
> include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83
> src/authorizer/authorizer.hpp b7f11191aea5deeea2403a6dd900eec9cc77ad56
> src/authorizer/authorizer.cpp 40a14becde44324bddefef1c6fe61b228ca505d3
> src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b
> src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797
> src/master/master.cpp 56306809096db36bc1884c87957a7b2c76610a93
> src/sasl/authenticator.hpp aa222d30eaf738d9ed1d46a6689e39b2283ec1c8
> src/tests/authorization_tests.cpp 611f3713c0bf4dee631a935f08c9edf2776ab3ad
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596
> src/tests/script.cpp 31294790f7146e5867067a0d45bd4d0e7d0885cd
>
> Diff: https://reviews.apache.org/r/24509/diff/
>
>
> Testing
> -------
>
> make check (WIP)
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24509: Refactored credentials and ACLs.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24509/#review50173
-----------------------------------------------------------
Bad patch!
Reviews applied: [24509]
Failed command: git apply --index 24509.patch
Error:
error: patch failed: 3rdparty/libprocess/include/process/defer.hpp:405
error: 3rdparty/libprocess/include/process/defer.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/include/process/deferred.hpp:31
error: 3rdparty/libprocess/include/process/deferred.hpp: patch does not apply
error: patch failed: include/mesos/mesos.proto:662
error: include/mesos/mesos.proto: patch does not apply
error: patch failed: src/authorizer/authorizer.hpp:49
error: src/authorizer/authorizer.hpp: patch does not apply
error: patch failed: src/authorizer/authorizer.cpp:54
error: src/authorizer/authorizer.cpp: patch does not apply
error: patch failed: src/credentials/credentials.hpp:53
error: src/credentials/credentials.hpp: patch does not apply
error: patch failed: src/master/flags.hpp:213
error: src/master/flags.hpp: patch does not apply
error: patch failed: src/master/http.cpp:39
error: src/master/http.cpp: patch does not apply
error: patch failed: src/master/master.hpp:422
error: src/master/master.hpp: patch does not apply
error: patch failed: src/master/master.cpp:1207
error: src/master/master.cpp: patch does not apply
error: patch failed: src/sasl/authenticator.hpp:466
error: src/sasl/authenticator.hpp: patch does not apply
error: patch failed: src/tests/authorization_tests.cpp:37
error: src/tests/authorization_tests.cpp: patch does not apply
error: patch failed: src/tests/master_authorization_tests.cpp:72
error: src/tests/master_authorization_tests.cpp: patch does not apply
error: patch failed: src/tests/mesos.hpp:492
error: src/tests/mesos.hpp: patch does not apply
error: patch failed: src/tests/reconciliation_tests.cpp:622
error: src/tests/reconciliation_tests.cpp: patch does not apply
error: patch failed: src/tests/script.cpp:135
error: src/tests/script.cpp: patch does not apply
- Mesos ReviewBot
On Aug. 8, 2014, 11:58 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24509/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 11:58 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1343
> https://issues.apache.org/jira/browse/MESOS-1343
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/defer.hpp dc2ec3bb4cc76bbef0dba2a4d7dd804f9ba1fa4a
> 3rdparty/libprocess/include/process/deferred.hpp 0552fb51f310b2ee0db7fbe31eabc6d161d1506e
> include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83
> src/authorizer/authorizer.hpp b7f11191aea5deeea2403a6dd900eec9cc77ad56
> src/authorizer/authorizer.cpp 40a14becde44324bddefef1c6fe61b228ca505d3
> src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0
> src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
> src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b
> src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797
> src/master/master.cpp 56306809096db36bc1884c87957a7b2c76610a93
> src/sasl/authenticator.hpp aa222d30eaf738d9ed1d46a6689e39b2283ec1c8
> src/tests/authorization_tests.cpp 611f3713c0bf4dee631a935f08c9edf2776ab3ad
> src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
> src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
> src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596
> src/tests/script.cpp 31294790f7146e5867067a0d45bd4d0e7d0885cd
>
> Diff: https://reviews.apache.org/r/24509/diff/
>
>
> Testing
> -------
>
> make check (WIP)
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 24509: Refactored credentials and ACLs.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24509/
-----------------------------------------------------------
(Updated Aug. 8, 2014, 11:58 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
added bug id.
Bugs: MESOS-1343
https://issues.apache.org/jira/browse/MESOS-1343
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/include/process/defer.hpp dc2ec3bb4cc76bbef0dba2a4d7dd804f9ba1fa4a
3rdparty/libprocess/include/process/deferred.hpp 0552fb51f310b2ee0db7fbe31eabc6d161d1506e
include/mesos/mesos.proto 6d4fd145004a14514e27ba65b2eae19b945aeb83
src/authorizer/authorizer.hpp b7f11191aea5deeea2403a6dd900eec9cc77ad56
src/authorizer/authorizer.cpp 40a14becde44324bddefef1c6fe61b228ca505d3
src/credentials/credentials.hpp 1790793ae8190fc5986c8dab089e9bdf32d55eb0
src/master/flags.hpp 2b92de37b64c3363915918c65ab092efd5b378d6
src/master/http.cpp f2ca6599eb165c4c1bc4580175fa439f797c832b
src/master/master.hpp d8a4d9e04ecff60020b99ea6447055787d187797
src/master/master.cpp 56306809096db36bc1884c87957a7b2c76610a93
src/sasl/authenticator.hpp aa222d30eaf738d9ed1d46a6689e39b2283ec1c8
src/tests/authorization_tests.cpp 611f3713c0bf4dee631a935f08c9edf2776ab3ad
src/tests/master_authorization_tests.cpp 009afa4186a7b69527ee28d8ad323315101947b6
src/tests/mesos.hpp 75c66fda2485afa0d4541e710780d90b3411839a
src/tests/reconciliation_tests.cpp 952f29b97e7516a3aa69e599901bf49cd2b6d596
src/tests/script.cpp 31294790f7146e5867067a0d45bd4d0e7d0885cd
Diff: https://reviews.apache.org/r/24509/diff/
Testing
-------
make check (WIP)
Thanks,
Benjamin Hindman