You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2019/02/14 13:50:19 UTC

[whimsy] branch master updated: Detect residual use of ou=pmc methods

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 42436b5  Detect residual use of ou=pmc methods
42436b5 is described below

commit 42436b518fe3aff1fea9a3d5076f6fec14b3f7ad
Author: Sebb <se...@apache.org>
AuthorDate: Thu Feb 14 13:50:18 2019 +0000

    Detect residual use of ou=pmc methods
---
 lib/whimsy/asf/ldap.rb | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/whimsy/asf/ldap.rb b/lib/whimsy/asf/ldap.rb
index 8590dec..a877529 100644
--- a/lib/whimsy/asf/ldap.rb
+++ b/lib/whimsy/asf/ldap.rb
@@ -1255,9 +1255,9 @@ module ASF
       (ASF::Committee.pmcs+ASF::Committee.nonpmcs).map(&:name).include?(name) ? committee : nil
     end
 
-    # DEPRECATED.  List of members for this committee.  Use owners as it
-    # is less ambiguous.
+    # DO NOT USE: relies on outdated ou=pmc LDAP. Uses owners instead.
     def members
+      Wunderbar.warn("Committee.members #{caller[0,4]}")
       members = weakref(:members) do
         ASF.search_one(base, "cn=#{name}", 'member').flatten
       end
@@ -1265,8 +1265,9 @@ module ASF
       members.map {|uid| Person.find uid[/uid=(.*?),/,1]}
     end
 
-    # List of ids in the member attribute for this committee
+    # DO NOT USE: relies on outdated ou=pmc LDAP. Uses ownerids instead.
     def memberids
+      Wunderbar.warn("Committee.memberids #{caller[0,4]}")
       members = weakref(:members) do
         ASF.search_one(base, "cn=#{name}", 'member').flatten
       end