You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Oleg Kalnichevski (JIRA)" <ji...@apache.org> on 2008/06/06 18:45:45 UTC
[jira] Created: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Transport base package is dependent on transport specific (VFS and Mail) classes
--------------------------------------------------------------------------------
Key: SYNAPSE-349
URL: https://issues.apache.org/jira/browse/SYNAPSE-349
Project: Synapse
Issue Type: Improvement
Components: Transports
Affects Versions: 1.2
Reporter: Oleg Kalnichevski
Priority: Minor
Fix For: 1.3
Attachments: basetransport.patch
The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
Patch to follow shortly.
Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Resolved: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved SYNAPSE-349.
-------------------------------------
Resolution: Fixed
The transport base classes now live in their own Maven module (in WS-Commons Transport) and this module only depends on AXIOM and the Axis2 kernel. It still (indirectly) depends on the javax.mail.internet package, but this is OK since both AXIOM and Axis2 depends on it. Therefore this issue can be considered as fixed.
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603152#action_12603152 ]
Andreas Veithen commented on SYNAPSE-349:
-----------------------------------------
There is currently no test case for SYNAPSE-260. It is true that the test coverage for the VFS transport is insufficient. I will try to work on this for the 1.3 release (see SYNAPSE-350).
I totally agree on your comment about recursive dependencies. At first I didn't understand the problem with the piece of code related to content type and charset encoding. It is the fact that it introduces a dependency on javax.mail.internet, right?
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated SYNAPSE-349:
--------------------------------------
Attachment: basetransport.patch
Please review.
Oleg
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603620#action_12603620 ]
Andreas Veithen commented on SYNAPSE-349:
-----------------------------------------
What issues other than the presence of the getMinPollTime and the usage of javax.mail.internet.ContentType did you identify? What are the first incremental changes that you see?
If there are many issues/changes, then we should first concentrate on the improvement of the unit tests (see SYNAPSE-246 and SYNAPSE-350).
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603629#action_12603629 ]
Oleg Kalnichevski commented on SYNAPSE-349:
-------------------------------------------
Andreas,
It is not about particular methods but rather about recursive dependencies between base transport package and individual transport packages. The proposed patch decouples the base package from VFS specific dependencies as the first step. We can deal with the dependency on javax.mail.internet later on .
Oleg
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603964#action_12603964 ]
Oleg Kalnichevski commented on SYNAPSE-349:
-------------------------------------------
Patch checked in.
Oleg
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603137#action_12603137 ]
Oleg Kalnichevski commented on SYNAPSE-349:
-------------------------------------------
Andreas,
Is there a test case for that issue? All tests seem to pass for me. Anyways, recursive dependencies between base package and concrete protocol implementations strike me as odd.
Oleg
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated SYNAPSE-349:
--------------------------------------
Attachment: (was: basetransport.patch)
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603893#action_12603893 ]
Andreas Veithen commented on SYNAPSE-349:
-----------------------------------------
The proposed patch looks fine for me.
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Updated: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated SYNAPSE-349:
--------------------------------------
Attachment: basetransport.patch
All right. Can we tackle this issue with a series of small, incremental changes then? Can we decouple base transport package from VFS for a start?
Oleg
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603183#action_12603183 ]
Oleg Kalnichevski commented on SYNAPSE-349:
-------------------------------------------
> It is the fact that it introduces a dependency on javax.mail.internet, right?
Yes, it is. Ideally base transport package should not have dependencies on any specific transport interfaces or classes
Oleg
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org
[jira] Commented: (SYNAPSE-349) Transport base package is dependent
on transport specific (VFS and Mail) classes
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SYNAPSE-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603131#action_12603131 ]
Andreas Veithen commented on SYNAPSE-349:
-----------------------------------------
Two comments:
* getMinPollTime doesn't seem to be used anywhere. We might as well remove it completely, given that the logic of that method is not very sophisticated and it would be easy to reimplement it when the need for it arises.
* Your patch partially undoes the modifications introduced to solve SYNAPSE-260 and will cause a regression. These modifications addressed a problem that appeared in the VFS transport. If they break other transports, then we need to figure out another solution that works correctly for all transports.
> Transport base package is dependent on transport specific (VFS and Mail) classes
> --------------------------------------------------------------------------------
>
> Key: SYNAPSE-349
> URL: https://issues.apache.org/jira/browse/SYNAPSE-349
> Project: Synapse
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 1.2
> Reporter: Oleg Kalnichevski
> Priority: Minor
> Fix For: 1.3
>
> Attachments: basetransport.patch
>
>
> The base transport package of Synapse is dependent on VFS and Mail specific classes, which seems wrong to me. Ideally the base transport classes should not depend on any transport specific aspects.
> Patch to follow shortly.
> Oleg
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org