You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/06 23:42:41 UTC

[GitHub] [kafka] anatasiavela commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

anatasiavela commented on code in PR #13078:
URL: https://github.com/apache/kafka/pull/13078#discussion_r1063885018


##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -576,6 +576,13 @@ class UnifiedLog(@volatile var logStartOffset: Long,
     }
   }, period = producerIdExpirationCheckIntervalMs, delay = producerIdExpirationCheckIntervalMs, unit = TimeUnit.MILLISECONDS)
 
+  // Visible for testing
+  def removeExpiredProducers(currentTimeMs: Long): Unit = {

Review Comment:
   yup, good catch. Reused that method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org