You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/04 07:08:31 UTC
[GitHub] [kafka] dajac opened a new pull request #10817: MINOR: Log member id of the leader when assignment are received
dajac opened a new pull request #10817:
URL: https://github.com/apache/kafka/pull/10817
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10817: MINOR: Log member id of the leader when assignment are received
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10817:
URL: https://github.com/apache/kafka/pull/10817#discussion_r646090260
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -567,7 +567,7 @@ class GroupCoordinator(val brokerId: Int,
// if this is the leader, then we can attempt to persist state and transition to stable
if (group.isLeader(memberId)) {
- info(s"Assignment received from leader for group ${group.groupId} for generation ${group.generationId}. " +
+ info(s"Assignment received from leader $memberId for group ${group.groupId} for generation ${group.generationId}. " +
Review comment:
nit: Should we wrap the variable with single/double quote to make it clear? Ex:
`info(s"Assignment received from leader '$memberId' for group '${group.groupId}' for generation '${group.generationId'}. `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #10817: MINOR: Log member id of the leader when assignment are received
Posted by GitBox <gi...@apache.org>.
dajac commented on a change in pull request #10817:
URL: https://github.com/apache/kafka/pull/10817#discussion_r646305571
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -567,7 +567,7 @@ class GroupCoordinator(val brokerId: Int,
// if this is the leader, then we can attempt to persist state and transition to stable
if (group.isLeader(memberId)) {
- info(s"Assignment received from leader for group ${group.groupId} for generation ${group.generationId}. " +
+ info(s"Assignment received from leader $memberId for group ${group.groupId} for generation ${group.generationId}. " +
Review comment:
@showuon At the moment, none of the other log in the group coordinator does this so it feel a bit weird to do it only in this case. I prefer keeping it as it is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #10817: MINOR: Log member id of the leader when assignment are received
Posted by GitBox <gi...@apache.org>.
dajac merged pull request #10817:
URL: https://github.com/apache/kafka/pull/10817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10817: MINOR: Log member id of the leader when assignment are received
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10817:
URL: https://github.com/apache/kafka/pull/10817#discussion_r646307665
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -567,7 +567,7 @@ class GroupCoordinator(val brokerId: Int,
// if this is the leader, then we can attempt to persist state and transition to stable
if (group.isLeader(memberId)) {
- info(s"Assignment received from leader for group ${group.groupId} for generation ${group.generationId}. " +
+ info(s"Assignment received from leader $memberId for group ${group.groupId} for generation ${group.generationId}. " +
Review comment:
No problem. Thank you. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org