Re: [PR] LRU DashMap to cache objectMeta [datafusion]

["matthewmturner (via GitHub)" <gi...@apache.org>]

matthewmturner commented on code in PR #10125:
URL: https://github.com/apache/datafusion/pull/10125#discussion_r1575437882


##########
datafusion/execution/src/cache/cache_unit.rs:
##########
@@ -232,4 +337,64 @@ mod tests {
             meta.clone()
         );
     }
+    #[test]

Review Comment:
   One thing that I think would be really helpful in validating if the cache is being used is showing it in our plans with EXPLAIN (i dont know which setting it would best belong in though - i.e. verbose or analyze).  For example I believe postgres exposes information like this through its `EXPLAIN BUFFERS`.  At this stage i dont think we need a new keyword though.
   
   Then we could have a test that just reads from a local file and we can assert on the plans output that the source of the file metadata is the cache.  This could also be extended for when we implement file caching.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org