You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/06 10:57:27 UTC
[GitHub] [maven-wrapper] timtebeek opened a new pull request, #61: Switch to JUnit Jupiter
timtebeek opened a new pull request, #61:
URL: https://github.com/apache/maven-wrapper/pull/61
Via mvn -U org.openrewrite.maven:rewrite-maven-plugin:4.32.0:run
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:1.26.1
-DactiveRecipes=org.openrewrite.java.testing.junit5.JUnit5BestPractices
<!--
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
-->
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062395101
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##########
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class SystemPropertiesHandlerTest
+class SystemPropertiesHandlerTest
Review Comment:
Hmm I just updated the parent to v38 and ran spotless:apply, but that seems to have given a lot more changes than I was expecting based on your comment.
Worst case I can always recreate the changes whenever the main branch is stable, as most of the changes are automated anyway. Let me know how best to proceed! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell merged pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
bmarwell merged PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060158379
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/WrapperExecutorTest.java:
##########
@@ -222,27 +226,27 @@ public void testEnvironmentVariableOverwrite_mvnwRepoUrl_trailingSlash()
WrapperExecutor wrapper = prepareWrapperExecutorWithEnvironmentVariables(environmentVariables);
- Assert.assertEquals( "https://repo/test/path/to/bin.zip", wrapper.getDistribution().toString() );
+ assertEquals( "https://repo/test/path/to/bin.zip", wrapper.getDistribution().toString() );
}
@Test
- public void testEnvironmentVariableOverwrite_packageName()
- throws Exception
+ void testEnvironmentVariableOverwrite_packageName()
+ throws Exception
{
final Map<String, String> environmentVariables = new HashMap<>();
environmentVariables.put( MVNW_REPOURL, "https://repo/test" );
properties = new Properties();
- properties.put( "distributionUrl", "https://server/org/apache/maven/to/bin.zip" );
- writePropertiesFile( properties, propertiesFile, "header" );
+ properties.put("distributionUrl", "https://server/org/apache/maven/to/bin.zip");
+ writePropertiesFile(properties, propertiesFile, "header");
Review Comment:
Style: you removed whitespace after the opening parenthesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062397142
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##########
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class SystemPropertiesHandlerTest
+class SystemPropertiesHandlerTest
Review Comment:
Huh... yeah, maybe that is better.
Can you recreate this PR and https://github.com/apache/maven-wrapper/pull/80 after I merge the v39 update as you suggested? That would be awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#issuecomment-1364555936
Yes I'd love to see this through, but will be traveling until early
January. Welcome to push the required changes already, or recreate using
the Maven plugin for OpenRewrite. Otherwise I'll pick this up as soon as I
get back.
On Thu, Dec 22, 2022, 11:54 Benjamin Marwell ***@***.***>
wrote:
> @timtebeek <https://github.com/timtebeek> it is now Java 8 -- would you
> like to change it back?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-wrapper/pull/61#issuecomment-1362934686>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAH22BUX53QWIZRQXNNY7DLWORTUDANCNFSM57QJ6HTQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] jorsol commented on pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
jorsol commented on PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#issuecomment-1226111255
This project uses Java 7, so I expect that this will not be compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1055548475
##########
maven-wrapper/pom.xml:
##########
@@ -34,18 +34,18 @@ under the License.
<description>Maven Wrapper Jar download, installs and launches installed target Maven distribution as part of Maven Wrapper scripts run.</description>
<dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<version>2.2</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
+ <version>5.9.0</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Please import the bom in dependency management
##########
maven-wrapper/pom.xml:
##########
@@ -34,18 +34,18 @@ under the License.
<description>Maven Wrapper Jar download, installs and launches installed target Maven distribution as part of Maven Wrapper scripts run.</description>
<dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<version>2.2</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter</artifactId>
+ <version>5.9.0</version>
Review Comment:
Optional: Extract to property (after switching to bom)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060406639
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##########
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class SystemPropertiesHandlerTest
+class SystemPropertiesHandlerTest
Review Comment:
Thanks, missed that! Will then change to approved and wait with merging until the new parent version is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek closed pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek closed pull request #61: Switch to JUnit Jupiter
URL: https://github.com/apache/maven-wrapper/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062399837
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##########
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class SystemPropertiesHandlerTest
+class SystemPropertiesHandlerTest
Review Comment:
Sure; I'll force push to #61 and #80 when #81 and it's [possible refactor followup](https://github.com/apache/maven-wrapper/pull/81#issuecomment-1372125545) are done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1062387739
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##########
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class SystemPropertiesHandlerTest
+class SystemPropertiesHandlerTest
Review Comment:
Actually, not so great. You will need to redo most of it b/c parent v39 requires a new style (which will cause a LOT of git merge conflicts): https://github.com/apache/maven-wrapper/pull/81
Maybe you just want to update here to v38 first before I do the v39 update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
bmarwell commented on PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#issuecomment-1362934686
@timtebeek it is now Java 8 -- would you like to change it back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1059926539
##########
maven-wrapper/pom.xml:
##########
@@ -33,27 +33,43 @@ under the License.
<name>Maven Wrapper Jar</name>
<description>Maven Wrapper Jar download, installs and launches installed target Maven distribution as part of Maven Wrapper scripts run.</description>
+ <properties>
+ <junit.version>5.9.1</junit.version>
+ <mockito.version>4.11.0</mockito.version>
+ </properties>
+
<dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<version>2.2</version>
Review Comment:
No property here as hamcrest was last released in 2019, and is unlikely to change in the future. Might want to swap Hamcrest for AssertJ, as it's only in two test classes. Suggest to tackle that separately from this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060445903
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##########
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class SystemPropertiesHandlerTest
+class SystemPropertiesHandlerTest
Review Comment:
Great; thanks for the thorough review; let me know if/when I need to rebase.
I'm expecting the parent change to also clear up the pipeline issue with mvn site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#issuecomment-1226322968
Good suggestion; applied just now, although it's not immediately clear to me whether this has any chance of getting merged (soon-ish), and/or what would be required to get it in a mergeable state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#issuecomment-1368797318
@bmarwell suggestions applied, and further fixes to reduce visibility and convert the new HashAlgorithmVerifierTest. Ready for review! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060158666
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##########
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class SystemPropertiesHandlerTest
+class SystemPropertiesHandlerTest
Review Comment:
We create test API docs. Please let all classes and methods be public. Tests fail because of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#issuecomment-1374585306
Resolved the conflicts just now; should be ready for a merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] slawekjaranowski commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060162000
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java:
##########
@@ -31,23 +31,23 @@
import java.util.Map;
import java.util.Properties;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-public class SystemPropertiesHandlerTest
+class SystemPropertiesHandlerTest
Review Comment:
from parent 38 it will be ok 😄
https://issues.apache.org/jira/browse/MPOM-340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060443396
##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/WrapperExecutorTest.java:
##########
@@ -222,27 +226,27 @@ public void testEnvironmentVariableOverwrite_mvnwRepoUrl_trailingSlash()
WrapperExecutor wrapper = prepareWrapperExecutorWithEnvironmentVariables(environmentVariables);
- Assert.assertEquals( "https://repo/test/path/to/bin.zip", wrapper.getDistribution().toString() );
+ assertEquals( "https://repo/test/path/to/bin.zip", wrapper.getDistribution().toString() );
}
@Test
- public void testEnvironmentVariableOverwrite_packageName()
- throws Exception
+ void testEnvironmentVariableOverwrite_packageName()
+ throws Exception
{
final Map<String, String> environmentVariables = new HashMap<>();
environmentVariables.put( MVNW_REPOURL, "https://repo/test" );
properties = new Properties();
- properties.put( "distributionUrl", "https://server/org/apache/maven/to/bin.zip" );
- writePropertiesFile( properties, propertiesFile, "header" );
+ properties.put("distributionUrl", "https://server/org/apache/maven/to/bin.zip");
+ writePropertiesFile(properties, propertiesFile, "header");
Review Comment:
Sorry about that; all these changes are automated, not sure why only here the whitespace handling was off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on a diff in pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1059934277
##########
maven-wrapper/pom.xml:
##########
@@ -33,27 +33,43 @@ under the License.
<name>Maven Wrapper Jar</name>
<description>Maven Wrapper Jar download, installs and launches installed target Maven distribution as part of Maven Wrapper scripts run.</description>
+ <properties>
+ <junit.version>5.9.1</junit.version>
+ <mockito.version>4.11.0</mockito.version>
+ </properties>
+
<dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<version>2.2</version>
Review Comment:
There's [no automated migration for Hamcrest yet](https://github.com/openrewrite/rewrite-testing-frameworks/issues/212), but that could be added in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#issuecomment-1373471124
@bmarwell recreated this one as well, as discussed; again mostly automated, with spotless apply committed separately from the OpenRewrite automation. Glad to see spotless added here. :) Ready for review & merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-wrapper] timtebeek commented on pull request #61: Switch to JUnit Jupiter
Posted by GitBox <gi...@apache.org>.
timtebeek commented on PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#issuecomment-1226115339
> This project uses Java 7, so I expect that this will not be compatible.
Ah hadn't thought of that; [you're right](https://junit.org/junit5/docs/current/user-guide/#overview-java-versions).
> JUnit 5 requires Java 8 (or higher) at runtime. However, you can still test code that has been compiled with previous versions of the JDK.
Unless we want to bring in toolchains to [test on a different Java version](https://vladmihalcea.com/different-java-main-test-maven/), I guess this is blocked for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org