You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/04/26 09:12:26 UTC

Review Request 33566: mesos: Removed and switched from memory:: to std::.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33566/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoortere.


Bugs: MESOS-2662
    https://issues.apache.org/jira/browse/MESOS-2662


Repository: mesos


Description
-------

See summary.


Diffs
-----

  src/linux/routing/internal.hpp aa607969ba30708006962abf249a7845c144ee57 
  src/local/local.cpp ab58a4a9efafa36711afa367fd22ab162bef76e4 
  src/master/http.cpp 00c22c43bd1f6cef7963b2ffa9c095c6cbd01cd3 
  src/master/main.cpp d141c76344ec5ba32210d60e9b66a58833a4f1dc 
  src/master/master.hpp bf1661abaf7775b11401f255e10d790a685885a9 
  src/master/master.cpp ce9d263558e6390c5ba3efaa1bcdc638f967412c 
  src/slave/http.cpp 914e7e5d0d6f5f628ba3c02e0dc23629d0a23512 
  src/slave/slave.hpp 1b8c5120691f24077c238895bf2a4c59f5b65146 
  src/slave/slave.cpp e531283e104ccc7865cfd912d15c7124732e7ae8 
  src/tests/cluster.hpp 26f4af2a346242e0b554ccb85a3432083811b4ab 
  src/tests/master_tests.cpp 840510555539485978f9ee4cf703e6af4504b01b 
  src/tests/mesos.hpp 4294e28f904161b473c0cfa7feea4eaa4e7c97e3 
  src/tests/mesos.cpp 1dde4fe8f58961ff6e8e00cc5ca99b1bc8a5c041 
  src/tests/scheduler_tests.cpp 9a2f30695ee6ba9b727f6ccf258a356f1a9ddc56 
  src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 

Diff: https://reviews.apache.org/r/33566/diff/


Testing
-------

make check


Thanks,

Michael Park


Re: Review Request 33566: mesos: Removed and switched from memory:: to std::.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33566/#review81629
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On April 26, 2015, 7:12 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33566/
> -----------------------------------------------------------
> 
> (Updated April 26, 2015, 7:12 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2662
>     https://issues.apache.org/jira/browse/MESOS-2662
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/routing/internal.hpp aa607969ba30708006962abf249a7845c144ee57 
>   src/local/local.cpp ab58a4a9efafa36711afa367fd22ab162bef76e4 
>   src/master/http.cpp 00c22c43bd1f6cef7963b2ffa9c095c6cbd01cd3 
>   src/master/main.cpp d141c76344ec5ba32210d60e9b66a58833a4f1dc 
>   src/master/master.hpp bf1661abaf7775b11401f255e10d790a685885a9 
>   src/master/master.cpp ce9d263558e6390c5ba3efaa1bcdc638f967412c 
>   src/slave/http.cpp 914e7e5d0d6f5f628ba3c02e0dc23629d0a23512 
>   src/slave/slave.hpp 1b8c5120691f24077c238895bf2a4c59f5b65146 
>   src/slave/slave.cpp e531283e104ccc7865cfd912d15c7124732e7ae8 
>   src/tests/cluster.hpp 26f4af2a346242e0b554ccb85a3432083811b4ab 
>   src/tests/master_tests.cpp 840510555539485978f9ee4cf703e6af4504b01b 
>   src/tests/mesos.hpp 4294e28f904161b473c0cfa7feea4eaa4e7c97e3 
>   src/tests/mesos.cpp 1dde4fe8f58961ff6e8e00cc5ca99b1bc8a5c041 
>   src/tests/scheduler_tests.cpp 9a2f30695ee6ba9b727f6ccf258a356f1a9ddc56 
>   src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 
> 
> Diff: https://reviews.apache.org/r/33566/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Michael Park
> 
>