You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Amrit Sarkar (JIRA)" <ji...@apache.org> on 2017/11/30 16:08:00 UTC
[jira] [Comment Edited] (SOLR-11676) nrt replicas is always 1 when
not specified
[ https://issues.apache.org/jira/browse/SOLR-11676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272856#comment-16272856 ]
Amrit Sarkar edited comment on SOLR-11676 at 11/30/17 4:07 PM:
---------------------------------------------------------------
Figured out. Attached patch, verified its working. {{ClusterStateTest}} is very poorly written in terms of verifying actual collection properties passed.
{code}
modified: solr/core/src/java/org/apache/solr/cloud/OverseerCollectionMessageHandler.java
modified: solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java
{code}
If we decide to write tests for the same, it will be tad difficult.
was (Author: sarkaramrit2@gmail.com):
Figured out. Attached patch, verified its working. {{ClusterStateTest}} is very poorly written in terms of verifying actual collection properties passed.
{code}
modified: solr/core/src/java/org/apache/solr/cloud/OverseerCollectionMessageHandler.java
modified: solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java
{code}
> nrt replicas is always 1 when not specified
> -------------------------------------------
>
> Key: SOLR-11676
> URL: https://issues.apache.org/jira/browse/SOLR-11676
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Attachments: SOLR-11676.patch
>
>
> I created 1 2 shard X 2 replica collection . Here's the log entry for it
> {code}
> 2017-11-27 06:43:47.071 INFO (qtp159259014-22) [ ] o.a.s.h.a.CollectionsHandler Invoked Collection Action :create with params replicationFactor=2&routerName=compositeId&collection.configName=_default&maxShardsPerNode=2&name=test_recovery&router.name=compositeId&action=CREATE&numShards=2&wt=json&_=1511764995711 and sendToOCPQueue=true
> {code}
> And then when I look at the state.json file I see nrtReplicas is set to 1. Any combination of numShards and replicationFactor without explicitly specifying the "nrtReplicas" param puts the "nrtReplicas" as 1 instead of using the replicationFactor value
> {code}
> {"test_recovery":{
> "pullReplicas":"0",
> "replicationFactor":"2",
> ...
> "nrtReplicas":"1",
> "tlogReplicas":"0",
> ..
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org