You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Mauro Talevi <ma...@aquilonia.org> on 2007/12/10 23:06:19 UTC
[Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox
As version 1.0-alpha-14 has been staged for release, I'd like to call a
vote for its release and the move out of the sandbox and to version
1.0-beta-1-SNAPSHOT.
Staging area:
http://people.apache.org/~mauro/staging-repo/
Tag:
http://svn.apache.org/repos/asf/maven/plugins/tags/maven-shade-plugin-1.0-alpha-14/
Vote open for 72 hours.
Here is my +1
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14
and move out of sandbox
Posted by Dan Fabulich <da...@fabulich.com>.
Mauro Talevi wrote:
> I've commented on MSHADE-7 - as far as I can tell, feature is already
> implemented, via shadedArtifact attachment. Please try out the configuration
> in:
MSHADE-7 is a very different feature from shadedArtifactAttached.
MSHADE-7 suggests that the generated classes just get dumped in with the
regular classes, so I can just write my code directly against the shaded
packages.
In that case, there would be no separate shaded artifact; the main
artifact would be the only artifact, and no need to replace.
shadedArtifactAttached appends a new artifact with -shaded classifier,
which isn't as helpful because the non-shaded artifact is usually trash.
-Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14
and move out of sandbox
Posted by Mauro Talevi <ma...@aquilonia.org>.
Dan Fabulich wrote:
>
> Uh, actually, I need to turn my vote to a -1. :-( I just discovered that
> I'm being bitten by MSHADE-5 (and MSHADE-6) every time I go to deploy
> the Surefire 2.4-SNAPSHOT. As a result, I deployed a corrupted
> SNAPSHOT... yuck!
>
> I just fixed MSHADE-6 in the sandbox, which would have at least
> prevented me from deploying a defective binary. I still don't see a
> great way to resolve MSHADE-5 except to pursue a strategy like the one
> described in MSHADE-7 (perhaps, as dkulp suggested, as an option).
>
> I'm going to go try to do the deploy directly from people.apache.org
> now. :-(
>
Dan,
I would seem to me MSHADE-5 is connected to Windows' less-than-optimal
filesystem management, I've never seen it on Unix. The fact that it
occurs only occasionally is a telling sign.
I've commented on MSHADE-7 - as far as I can tell, feature is already
implemented, via shadedArtifact attachment. Please try out the
configuration in:
http://svn.apache.org/repos/asf/maven/plugins/tags/maven-shade-plugin-1.0-alpha-14/src/test/projects/shaded-attached-project/pom.xml
Cheers
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14
and move out of sandbox
Posted by Mauro Talevi <ma...@aquilonia.org>.
Brian E. Fox wrote:
> It would be cool if you could try the new candidate on 2.0.x also. I had
> trouble with it excluding tons of stuff when I did 2.0.8. I can try it
> later today if you can't.
Built a 2.0.9 snapshot and try it out on a sample projects.
No problems encountered. So it does look promising.
I would stage an alpha-15 release and let people loose on it.
Cheers
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox
Posted by "Brian E. Fox" <br...@reply.infinity.nu>.
It would be cool if you could try the new candidate on 2.0.x also. I had
trouble with it excluding tons of stuff when I did 2.0.8. I can try it
later today if you can't.
-----Original Message-----
From: Daniel Kulp [mailto:dkulp@apache.org]
Sent: Tuesday, December 11, 2007 11:51 AM
To: dev@maven.apache.org
Cc: Dan Fabulich
Subject: Re: Changed vote Re: [Vote] maven-shade-plugin release
1.0-alpha-14 and move out of sandbox
OK. I fixed one more issue with it. Can you give it another try. :-)
Getting closer.....
Dan
On Tuesday 11 December 2007, Dan Fabulich wrote:
> Fixed on my end (I think... this bug is finicky); try it on your end
> to make sure I didn't break anything further?
>
> -Dan
>
> Dan Fabulich wrote:
> > Daniel Kulp wrote:
> >> I changed the rename logic to do a whole bunch of fallback things
> >> if the first rename fails. It first will try a gc to see if any
> >> Streams that are holding it locked can be cleaned up. If that
> >> still fails, then it will just copy the new file over the old file.
> >> Not ideal, but it should hopefully work.
> >
> > Seems like this strategy might have worked, but now it's buggy.
> > When I ran it just now it failed to install the jar, because it
> > wasn't there at all... All I had was
> > original-surefire-api-2.4-SNAPSHOT-shaded.jar and
> > surefire-api-2.4-SNAPSHOT-shaded.jar; install failed because I was
> > missing plain old surefire-api-2.4-SNAPSHOT.jar.
> >
> > I'll try to poke around with it a bit today.
> >
> > -Dan
> >
> > --------------------------------------------------------------------
> >- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14
and move out of sandbox
Posted by Dan Fabulich <da...@fabulich.com>.
Daniel Kulp wrote:
> OK. I fixed one more issue with it. Can you give it another try. :-)
>
> Getting closer.....
Yup, looks good to me. I've closed MSHADE-5 again.
-Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox
Posted by Daniel Kulp <dk...@apache.org>.
OK. I fixed one more issue with it. Can you give it another try. :-)
Getting closer.....
Dan
On Tuesday 11 December 2007, Dan Fabulich wrote:
> Fixed on my end (I think... this bug is finicky); try it on your end
> to make sure I didn't break anything further?
>
> -Dan
>
> Dan Fabulich wrote:
> > Daniel Kulp wrote:
> >> I changed the rename logic to do a whole bunch of fallback things
> >> if the first rename fails. It first will try a gc to see if any
> >> Streams that are holding it locked can be cleaned up. If that
> >> still fails, then it will just copy the new file over the old file.
> >> Not ideal, but it should hopefully work.
> >
> > Seems like this strategy might have worked, but now it's buggy.
> > When I ran it just now it failed to install the jar, because it
> > wasn't there at all... All I had was
> > original-surefire-api-2.4-SNAPSHOT-shaded.jar and
> > surefire-api-2.4-SNAPSHOT-shaded.jar; install failed because I was
> > missing plain old surefire-api-2.4-SNAPSHOT.jar.
> >
> > I'll try to poke around with it a bit today.
> >
> > -Dan
> >
> > --------------------------------------------------------------------
> >- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14
and move out of sandbox
Posted by Dan Fabulich <da...@fabulich.com>.
Fixed on my end (I think... this bug is finicky); try it on your end to
make sure I didn't break anything further?
-Dan
Dan Fabulich wrote:
> Daniel Kulp wrote:
>
>> I changed the rename logic to do a whole bunch of fallback things if the
>> first rename fails. It first will try a gc to see if any Streams that are
>> holding it locked can be cleaned up. If that still fails, then it will
>> just copy the new file over the old file. Not ideal, but it should
>> hopefully work.
>
> Seems like this strategy might have worked, but now it's buggy. When I ran
> it just now it failed to install the jar, because it wasn't there at all...
> All I had was original-surefire-api-2.4-SNAPSHOT-shaded.jar and
> surefire-api-2.4-SNAPSHOT-shaded.jar; install failed because I was missing
> plain old surefire-api-2.4-SNAPSHOT.jar.
>
> I'll try to poke around with it a bit today.
>
> -Dan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14
and move out of sandbox
Posted by Dan Fabulich <da...@fabulich.com>.
Daniel Kulp wrote:
> I changed the rename logic to do a whole bunch of fallback things if the
> first rename fails. It first will try a gc to see if any Streams that
> are holding it locked can be cleaned up. If that still fails, then it
> will just copy the new file over the old file. Not ideal, but it should
> hopefully work.
Seems like this strategy might have worked, but now it's buggy. When I
ran it just now it failed to install the jar, because it wasn't there at
all... All I had was original-surefire-api-2.4-SNAPSHOT-shaded.jar and
surefire-api-2.4-SNAPSHOT-shaded.jar; install failed because I was missing
plain old surefire-api-2.4-SNAPSHOT.jar.
I'll try to poke around with it a bit today.
-Dan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of sandbox
Posted by Daniel Kulp <dk...@apache.org>.
Dan,
Can you try a deploy with 1.0-alpha-15-SNAPSHOT?
I changed the rename logic to do a whole bunch of fallback things if the
first rename fails. It first will try a gc to see if any Streams that
are holding it locked can be cleaned up. If that still fails, then it
will just copy the new file over the old file. Not ideal, but it
should hopefully work.
Dan
On Tuesday 11 December 2007, Dan Fabulich wrote:
> Uh, actually, I need to turn my vote to a -1. :-( I just discovered
> that I'm being bitten by MSHADE-5 (and MSHADE-6) every time I go to
> deploy the Surefire 2.4-SNAPSHOT. As a result, I deployed a corrupted
> SNAPSHOT... yuck!
>
> I just fixed MSHADE-6 in the sandbox, which would have at least
> prevented me from deploying a defective binary. I still don't see a
> great way to resolve MSHADE-5 except to pursue a strategy like the one
> described in MSHADE-7 (perhaps, as dkulp suggested, as an option).
>
> I'm going to go try to do the deploy directly from people.apache.org
> now.
>
> :-(
>
> -Dan
>
> Dan Fabulich wrote:
> > +1. This works with the latest Surefire trunk. (It's a pity
> > MSHADE-9 is still broken, but I think it's OK for another alpha; we
> > should fix it for beta-1.)
> >
> > -Dan
> >
> > Mauro Talevi wrote:
> >> As version 1.0-alpha-14 has been staged for release, I'd like to
> >> call a vote for its release and the move out of the sandbox and to
> >> version 1.0-beta-1-SNAPSHOT.
> >>
> >>
> >> Staging area:
> >> http://people.apache.org/~mauro/staging-repo/
> >>
> >> Tag:
> >> http://svn.apache.org/repos/asf/maven/plugins/tags/maven-shade-plug
> >>in-1.0-alpha-14/
> >>
> >> Vote open for 72 hours.
> >>
> >> Here is my +1
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >>
> >>
> >> -------------------------------------------------------------------
> >>-- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> > --------------------------------------------------------------------
> >- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
daniel.kulp@iona.com
http://www.dankulp.com/blog
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Changed vote Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and
move out of sandbox
Posted by Dan Fabulich <da...@fabulich.com>.
Uh, actually, I need to turn my vote to a -1. :-( I just discovered that
I'm being bitten by MSHADE-5 (and MSHADE-6) every time I go to deploy the
Surefire 2.4-SNAPSHOT. As a result, I deployed a corrupted SNAPSHOT...
yuck!
I just fixed MSHADE-6 in the sandbox, which would have at least prevented
me from deploying a defective binary. I still don't see a great way to
resolve MSHADE-5 except to pursue a strategy like the one described in
MSHADE-7 (perhaps, as dkulp suggested, as an option).
I'm going to go try to do the deploy directly from people.apache.org now.
:-(
-Dan
Dan Fabulich wrote:
> +1. This works with the latest Surefire trunk. (It's a pity MSHADE-9 is
> still broken, but I think it's OK for another alpha; we should fix it for
> beta-1.)
>
> -Dan
>
> Mauro Talevi wrote:
>
>> As version 1.0-alpha-14 has been staged for release, I'd like to call a
>> vote for its release and the move out of the sandbox and to version
>> 1.0-beta-1-SNAPSHOT.
>>
>>
>> Staging area:
>> http://people.apache.org/~mauro/staging-repo/
>>
>> Tag:
>> http://svn.apache.org/repos/asf/maven/plugins/tags/maven-shade-plugin-1.0-alpha-14/
>>
>> Vote open for 72 hours.
>>
>> Here is my +1
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [Vote] maven-shade-plugin release 1.0-alpha-14 and move out of
sandbox
Posted by Dan Fabulich <da...@fabulich.com>.
+1. This works with the latest Surefire trunk. (It's a pity MSHADE-9 is
still broken, but I think it's OK for another alpha; we should fix it for
beta-1.)
-Dan
Mauro Talevi wrote:
> As version 1.0-alpha-14 has been staged for release, I'd like to call a vote
> for its release and the move out of the sandbox and to version
> 1.0-beta-1-SNAPSHOT.
>
>
> Staging area:
> http://people.apache.org/~mauro/staging-repo/
>
> Tag:
> http://svn.apache.org/repos/asf/maven/plugins/tags/maven-shade-plugin-1.0-alpha-14/
>
> Vote open for 72 hours.
>
> Here is my +1
>
> [ ] +1
> [ ] +0
> [ ] -1
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org