You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/07 06:18:30 UTC
[GitHub] [airflow] mik-laj commented on a change in pull request #20095: Modernize tests for SnowflakeHook
mik-laj commented on a change in pull request #20095:
URL: https://github.com/apache/airflow/pull/20095#discussion_r763667179
##########
File path: tests/providers/snowflake/hooks/test_snowflake.py
##########
@@ -16,340 +16,243 @@
# specific language governing permissions and limitations
# under the License.
#
-import os
+import pathlib
import re
import unittest
+from pathlib import Path
from unittest import mock
+import pytest
from cryptography.hazmat.backends import default_backend
from cryptography.hazmat.primitives import serialization
from cryptography.hazmat.primitives.asymmetric import rsa
-from parameterized import parameterized
+from py._path.local import LocalPath
Review comment:
Done. https://github.com/apache/airflow/pull/20095/commits/6f164b9016fb4c543958b7a7fb517ed80e26aa23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org