[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2254: Cassandra 12937 sstable compression rebased to trunk

["smiklosovic (via GitHub)" <gi...@apache.org>]

smiklosovic commented on code in PR #2254:
URL: https://github.com/apache/cassandra/pull/2254#discussion_r1176654278


##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,48 @@ commitlog_segment_size: 32MiB
 #
 # flush_compression: fast
 
+#
+sstable_compressor:

Review Comment:
   @Claudenw this should be `sstable_compression`. We have `commitlog_compression` as well as `hints_compression`. We have even `internode_compression` and `flush_compression`. No reason to have `sstable_compressor` instead of `sstable_compression`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org