You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/17 21:32:39 UTC
[kudu-CR] [build] Fix buildSrc lock timeout
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15470
Change subject: [build] Fix buildSrc lock timeout
......................................................................
[build] Fix buildSrc lock timeout
I have seen a few instances where the `make` build fails in a fresh
environment with the below error about a buildSrc lock:
`Timeout waiting to lock buildSrc build lock. It is currently in use by another Gradle instance.`
However, I have not seen this at all in pre-commit builds where
the environment isn’t wiped or in developer environments.
I think the issue is that building the buildSrc module for the first time
takes too long because it needs to pull dependencies and doesn’t
have a cache to use.
This patch adds an extra step in the cmake Gradle initialization
to actually call a project task to ensure the buildSrc module is
initialized.
Change-Id: I26444e6d2f8fffca1d070a591710bd7382063624
---
M CMakeLists.txt
M java/build.gradle
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15470/1
--
To view, visit http://gerrit.cloudera.org:8080/15470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26444e6d2f8fffca1d070a591710bd7382063624
Gerrit-Change-Number: 15470
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fix buildSrc lock timeout
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15470 )
Change subject: [build] Fix buildSrc lock timeout
......................................................................
[build] Fix buildSrc lock timeout
I have seen a few instances where the `make` build fails in a fresh
environment with the below error about a buildSrc lock:
`Timeout waiting to lock buildSrc build lock. It is currently in use by another Gradle instance.`
However, I have not seen this at all in pre-commit builds where
the environment isn’t wiped or in developer environments.
I think the issue is that building the buildSrc module for the first time
takes too long because it needs to pull dependencies and doesn’t
have a cache to use.
This patch adds an extra step in the cmake Gradle initialization
to actually call a project task to ensure the buildSrc module is
initialized.
Change-Id: I26444e6d2f8fffca1d070a591710bd7382063624
Reviewed-on: http://gerrit.cloudera.org:8080/15470
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M CMakeLists.txt
M java/build.gradle
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26444e6d2f8fffca1d070a591710bd7382063624
Gerrit-Change-Number: 15470
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix buildSrc lock timeout
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15470 )
Change subject: [build] Fix buildSrc lock timeout
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15470/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/15470/1/CMakeLists.txt@109
PS1, Line 109: COMMAND ./gradlew --version ${GRADLE_FLAGS}
> Could we drop this step now?
We could but it takes almost no extra time and actually has proven useful when debugging.
--
To view, visit http://gerrit.cloudera.org:8080/15470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26444e6d2f8fffca1d070a591710bd7382063624
Gerrit-Change-Number: 15470
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 21:56:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix buildSrc lock timeout
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15470 )
Change subject: [build] Fix buildSrc lock timeout
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15470/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/15470/1/CMakeLists.txt@109
PS1, Line 109: COMMAND ./gradlew --version ${GRADLE_FLAGS}
Could we drop this step now?
--
To view, visit http://gerrit.cloudera.org:8080/15470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26444e6d2f8fffca1d070a591710bd7382063624
Gerrit-Change-Number: 15470
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 21:48:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix buildSrc lock timeout
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15470 )
Change subject: [build] Fix buildSrc lock timeout
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26444e6d2f8fffca1d070a591710bd7382063624
Gerrit-Change-Number: 15470
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Mar 2020 21:55:25 +0000
Gerrit-HasComments: No