You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/26 14:37:21 UTC
[GitHub] [apisix] hf400159 opened a new pull request, #7146: docs: update zipkin Chinese doc
hf400159 opened a new pull request, #7146:
URL: https://github.com/apache/apisix/pull/7146
### Description
update zipkin Chinese doc.
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7146: docs: update zipkin Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #7146:
URL: https://github.com/apache/apisix/pull/7146#discussion_r883204460
##########
docs/zh/latest/plugins/zipkin.md:
##########
@@ -150,23 +199,26 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1
}'
```
-访问服务：
+接下来你可以通过以下命令发起请求，并且这条请求记录将会出现在 Jaeger 中：
Review Comment:
```suggestion
接下来你可以通过以下命令发起请求，该条请求记录将会出现在 Jaeger 中：
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7146: docs: update zipkin Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #7146:
URL: https://github.com/apache/apisix/pull/7146#discussion_r883204665
##########
docs/zh/latest/plugins/zipkin.md:
##########
@@ -150,23 +199,26 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f1
}'
```
-访问服务：
+接下来你可以通过以下命令发起请求，并且这条请求记录将会出现在 Jaeger 中：
```shell
curl http://127.0.0.1:9080/index.html
+```
+
+```
HTTP/1.1 200 OK
...
```
-然后在浏览器中打开`http://127.0.0.1:16686`，在 Jaeger WebUI 上查询 traces：
+然后你可以在浏览器中输入 `http://127.0.0.1:16686` 访问 Jaeger UI 查看 traces：
Review Comment:
```suggestion
最后你可以在浏览器中输入 `http://127.0.0.1:16686` 访问 Jaeger UI 查看 traces：
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7146: docs: update zipkin Chinese doc
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7146:
URL: https://github.com/apache/apisix/pull/7146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7146: docs: update zipkin Chinese doc
Posted by GitBox <gi...@apache.org>.
SylviaBABY commented on code in PR #7146:
URL: https://github.com/apache/apisix/pull/7146#discussion_r883204855
##########
docs/zh/latest/plugins/zipkin.md:
##########
@@ -126,9 +175,9 @@ docker run -d --name jaeger \
jaegertracing/all-in-one:1.31
```
-创建路由，并且配置 Zipkin：
+通过以下命令创建一个路由并启用插件：
Review Comment:
```suggestion
通过以下命令创建路由并启用插件：
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org