You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/07 02:11:02 UTC

[GitHub] [spark] sarutak commented on a change in pull request #29958: [SPARK-33079][TESTS] Add Scala 2.13 build test in GitHub Action for SBT

sarutak commented on a change in pull request #29958:
URL: https://github.com/apache/spark/pull/29958#discussion_r500696490



##########
File path: .github/workflows/build_and_test.yml
##########
@@ -319,3 +319,29 @@ jobs:
         ./dev/change-scala-version.sh 2.13
         ./build/mvn $MAVEN_CLI_OPTS -DskipTests -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-cloud -Djava.version=11 -Pscala-2.13 install
         rm -rf ~/.m2/repository/org/apache/spark
+
+  scala-213-sbt:
+    name: Scala 2.13 build with SBT

Review comment:
       > The (almost) same thing is tested at "Scala 2.13 build"
   
   The main purpose of adding the build with SBT is not just testing with SBT. As I mentioned, some compilation error happens only with SBT so I'd like detect such error before any changes being merged. 
   I understand we have not enough resource for GitHub Action but if an additional build is added to the Jenkins regular job, it will take much more longer time doesn't it?
   Are there any problem to replace the existing "Scala 2.13 build" with the new one?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org