[GitHub] [superset] rusackas commented on a change in pull request #13500: chore(homepage): separate out api calls to make homepage load more dynamically

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #13500:
URL: https://github.com/apache/superset/pull/13500#discussion_r590891630



##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -61,102 +61,92 @@ const createFetchResourceMethod = (method: string) => (
   return [];
 };
 
-export const getRecentAcitivtyObjs = (
-  userId: string | number,
-  recent: string,
-  addDangerToast: (arg1: string, arg2: any) => any,
-) => {
-  const getParams = (filters?: Array<any>) => {
-    const params = {
-      order_column: 'changed_on_delta_humanized',
-      order_direction: 'desc',
-      page: 0,
-      page_size: 3,
-      filters,
-    };
-    if (!filters) delete params.filters;
-    return rison.encode(params);
+const getParams = (filters?: Array<any>) => {

Review comment:
       I wonder if we can type this more specifically.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org