[jira] [Updated] (MYFACES-2489) Clean up the viewId calculation algorithm

["Thomas Andraschko (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/MYFACES-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Andraschko updated MYFACES-2489:
---------------------------------------
       Resolution: Fixed
         Assignee: Thomas Andraschko
    Fix Version/s: 3.0.0-SNAPSHOT
           Status: Resolved  (was: Patch Available)

Did a cleanup but the "deriveLogicalViewId" is still called 3 times. We could fix this, however i'm not sure if this would break something from specs perspective. I didn't apply this changes for now.

> Clean up the viewId calculation algorithm
> -----------------------------------------
>
>                 Key: MYFACES-2489
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2489
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha-2
>            Reporter: Jakob Korherr
>            Assignee: Thomas Andraschko
>            Priority: Major
>             Fix For: 3.0.0-SNAPSHOT
>
>         Attachments: MYFACES-2489-core.patch, MYFACES-2489-shared.patch, myfaces-2489.patch
>
>
> The whole viewId calculation process is a big mess. There is DefaultRestoreViewSupport with calculateViewId and deriveViewId and there is DefaultViewHandlerSupport with calculateViewId and calculateAndCheckViewId.
> Furthermore each viewId gets calculated twice (e.g. first from test.jsf to test.xhtml and then from test.xhtml to test.xhtml, which is not necessary).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)