You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/10/12 18:20:34 UTC
[GitHub] [trafficcontrol] jhg03a commented on a change in pull request #5137: Docker files for CentOS 8 build for 4.1.x
jhg03a commented on a change in pull request #5137:
URL: https://github.com/apache/trafficcontrol/pull/5137#discussion_r503455599
##########
File path: infrastructure/docker/build/Dockerfile-traffic_monitor-el8
##########
@@ -0,0 +1,52 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+FROM centos:8
+
+MAINTAINER dev@trafficcontrol.apache.org
+
+# top level of trafficcontrol directory must be mounted as a volume:
+# docker run --volume /trafficcontrol:$(pwd) ...
+VOLUME /trafficcontrol
+
+### Common for all sub-component builds
+RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial && \
+ rpm --import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-8 && \
+ yum -y update ca-certificates && \
+ yum -y install \
+ epel-release \
+ rsync && \
+ yum -y clean all
+
+### traffic_monitor specific requirements
+RUN yum -y install \
+ # gcc is necessary in case -gcflags 'all=-N -l' is passed to go build
+ gcc \
+ git \
+ rpm-build && \
+ yum -y clean all
+
+RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \
+ tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \
+ ln -s /usr/local/go/bin/go /usr/bin/go && \
+ rm go1.14.2.linux-amd64.tar.gz
+
Review comment:
There were some recent modifications to upgrade to Golang 15
##########
File path: infrastructure/docker/build/Dockerfile-traffic_monitor-el7
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+FROM centos:7
+
+MAINTAINER dev@trafficcontrol.apache.org
+
+# top level of trafficcontrol directory must be mounted as a volume:
+# docker run --volume /trafficcontrol:$(pwd) ...
+VOLUME /trafficcontrol
+
+### Common for all sub-component builds
+RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 && \
+ rpm --import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 && \
+ yum -y update ca-certificates && \
+ yum -y install \
+ epel-release && \
+ yum -y clean all
+
+### traffic_monitor specific requirements
+RUN yum -y install \
+ # gcc is necessary in case -gcflags 'all=-N -l' is passed to go build
+ gcc \
+ git \
+ rpm-build && \
+ yum -y clean all
+
+RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \
+ tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \
+ ln -s /usr/local/go/bin/go /usr/bin/go && \
+ rm go1.14.2.linux-amd64.tar.gz
Review comment:
There were some recent modifications to upgrade to Golang 15
##########
File path: infrastructure/docker/build/Dockerfile-traffic_ops-el8
##########
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+FROM centos:8
+
+MAINTAINER dev@trafficcontrol.apache.org
+
+# top level of trafficcontrol directory must be mounted as a volume:
+# docker run --volume /trafficcontrol:$(pwd) ...
+VOLUME /trafficcontrol
+
+### Common for all sub-component builds
+RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial && \
+ rpm --import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-8 && \
+ yum -y update ca-certificates && \
+ yum -y install \
+ epel-release \
+ rsync && \
+ yum -y clean all
+
+### traffic_ops specific requirements
+RUN yum -y install \
+ expat-devel \
+ gcc \
+ git \
+ libcurl-devel \
+ make \
+ openssl-devel \
+ perl-ExtUtils-MakeMaker \
+ rpm-build \
+ tar && \
+ yum -y clean all
+
+RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \
+ tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \
+ ln -s /usr/local/go/bin/go /usr/bin/go && \
+ rm go1.14.2.linux-amd64.tar.gz
Review comment:
There were some recent modifications to upgrade to Golang 15
##########
File path: infrastructure/docker/build/Dockerfile-traffic_ops-el7
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+FROM centos:7
+
+MAINTAINER dev@trafficcontrol.apache.org
+
+# top level of trafficcontrol directory must be mounted as a volume:
+# docker run --volume /trafficcontrol:$(pwd) ...
+VOLUME /trafficcontrol
+
+### Common for all sub-component builds
+RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 && \
+ rpm --import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 && \
+ yum -y update ca-certificates && \
+ yum -y install \
+ epel-release && \
+ yum -y clean all
+
+### traffic_ops specific requirements
+RUN yum -y install \
+ expat-devel \
+ gcc \
+ git \
+ libcurl-devel \
+ make \
+ openssl-devel \
+ perl-ExtUtils-MakeMaker \
+ rpm-build \
+ tar && \
+ yum -y clean all
+
+RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \
+ tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \
+ ln -s /usr/local/go/bin/go /usr/bin/go && \
+ rm go1.14.2.linux-amd64.tar.gz
Review comment:
There were some recent modifications to upgrade to Golang 15
##########
File path: infrastructure/docker/build/Dockerfile-traffic_stats-el8
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+FROM centos:8
+
+MAINTAINER dev@trafficcontrol.apache.org
+
+# top level of trafficcontrol directory must be mounted as a volume:
+# docker run --volume /trafficcontrol:$(pwd) ...
+VOLUME /trafficcontrol
+
+### Common for all sub-component builds
+RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial && \
+ rpm --import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-8 && \
+ yum -y update ca-certificates && \
+ yum -y install \
+ epel-release \
+ rsync && \
+ yum -y clean all
+
+### traffic_stats specific requirements
+RUN yum -y install \
+ git \
+ rpm-build && \
+ yum -y clean all
+
+RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \
+ tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \
+ ln -s /usr/local/go/bin/go /usr/bin/go && \
+ rm go1.14.2.linux-amd64.tar.gz
Review comment:
There were some recent modifications to upgrade to Golang 15
##########
File path: infrastructure/docker/build/Dockerfile-traffic_stats-el7
##########
@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+FROM centos:7
+
+MAINTAINER dev@trafficcontrol.apache.org
+
+# top level of trafficcontrol directory must be mounted as a volume:
+# docker run --volume /trafficcontrol:$(pwd) ...
+VOLUME /trafficcontrol
+
+### Common for all sub-component builds
+RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 && \
+ rpm --import https://dl.fedoraproject.org/pub/epel/RPM-GPG-KEY-EPEL-7 && \
+ yum -y update ca-certificates && \
+ yum -y install \
+ epel-release && \
+ yum -y clean all
+
+### traffic_stats specific requirements
+RUN yum -y install \
+ git \
+ rpm-build && \
+ yum -y clean all
+
+RUN curl -LO https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz && \
+ tar -C /usr/local -xvzf go1.14.2.linux-amd64.tar.gz && \
+ ln -s /usr/local/go/bin/go /usr/bin/go && \
+ rm go1.14.2.linux-amd64.tar.gz
Review comment:
There were some recent modifications to upgrade to Golang 15
##########
File path: infrastructure/docker/build/docker-compose-combo.yml
##########
@@ -0,0 +1,98 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: '2'
+
+services:
+ source:
+ image: trafficcontrol_tarball
+ build:
+ dockerfile: infrastructure/docker/build/Dockerfile-source
+ context: ../../..
+ volumes:
+ - ../../..:/trafficcontrol:z
+
+ traffic_monitor_build:
+ image: traffic_monitor_builder
+ build:
+ dockerfile: infrastructure/docker/build/Dockerfile-traffic_monitor-${COS_VERSION}
Review comment:
Might be a good idea to have a default `COS_VERSION` specified for 7. Docker variable intepolation should support this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org