You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jiangzhx (via GitHub)" <gi...@apache.org> on 2023/03/25 02:58:50 UTC
[GitHub] [arrow-datafusion] jiangzhx opened a new pull request, #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
jiangzhx opened a new pull request, #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
excluding doctests for mac/win64 platform ,Make them consistent with amd64
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730#issuecomment-1485781968
The tests look good to me. Thank you @jiangzhx 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730#issuecomment-1485657365
🤔 interestingly the CI tests did not trigger on this PR, which I noticed when trying to check the timings. I will fix that too and hopefully we can see the effect on this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730#discussion_r1148363410
##########
.github/workflows/rust.yml:
##########
@@ -248,11 +248,11 @@ jobs:
rustup toolchain install stable
rustup default stable
rustup component add rustfmt
- - name: Run tests
+ - name: Run tests (excluding doctests)
shell: bash
run: |
export PATH=$PATH:$HOME/d/protoc/bin
- cargo test
+ cargo test --lib --tests --bins --features avro,jit,scheduler,json,dictionary_expressions
Review Comment:
I think it is a reasonable idea to run with the same features on mac and windows. Thank you @jiangzhx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730#issuecomment-1483815676
Can you please explain a little about the rationale for this change (why you made it)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jiangzhx commented on pull request #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx commented on PR #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730#issuecomment-1483699366
BTW: cargo test(win64) is much slower than amd64 and mac
<img width="949" alt="image" src="https://user-images.githubusercontent.com/494507/227687993-c9746db6-799b-41d2-b3cd-ac8cbbb32d76.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jiangzhx commented on pull request #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
Posted by "jiangzhx (via GitHub)" <gi...@apache.org>.
jiangzhx commented on PR #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730#issuecomment-1484467592
> Can you please explain a little about the rationale for this change (why you made it)?
I found that cargo test (win64) is much slower than amd64 and mac.
is it because something else is being done in the win64 environment than in the amd64 environment.
if we can make them consistent with amd64, which would make it easier to identify reason .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5730: excluding doctests for mac/win64 platform ,Make them consistent with amd64
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5730:
URL: https://github.com/apache/arrow-datafusion/pull/5730#issuecomment-1485673708
Testing CI with https://github.com/apache/arrow-datafusion/pull/5759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org