You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2024/04/22 16:44:16 UTC
[PR] [improve][cli] Add generate-completion command to admin and client [pulsar]
nodece opened a new pull request, #22557:
URL: https://github.com/apache/pulsar/pull/22557
### Motivation
The tab-completion is a important feature, we migrate the CLI parser to picocli from jcommander, right now we can use the picocli autocomplete to do that.
- pulsar-admin
```
❯ source <(bin/pulsar-admin generate-completion)
❯ bin/pulsar-admin topics clear-backlog --subscription
--help --subscription --version -h -s -v
```
- pulsar-client
```
❯ source <(bin/pulsar-client generate-completion)
❯ bin/pulsar-client produce -h
--chunking --files --key-value-key --rate -db -h -kvkf -s
--disable-batching --help --key-value-key-file --separator -dr -k -m -v
--disable-replication --key --messages --value-schema -ekn -ks -n -vs
--encryption-key-name --key-schema --num-produce --version -ekv -kvet -p
--encryption-key-value --key-value-encoding-type --properties -c -f -kvk -r
```
### Modifications
- Add `generate-completion` command to the `pulsar-admin` and `pulsar-client`
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][cli] Add generate-completion command to admin and client [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #22557:
URL: https://github.com/apache/pulsar/pull/22557#issuecomment-6182246170
Hi @nodece, thanks for the contribution, and sorry it never got a proper review. Shell completion for pulsar-admin and pulsar-client hasn't found a reviewer or users asking for it while this has been open, and the build has since moved to Gradle, so it would need to be redone on current master. We're going through the backlog of open PRs (https://lists.apache.org/thread/cgy7w0qgnq8s7j0ykyzgrn3hj4nb67wf), so I'm closing this one. If there's interest in it, feel free to open a fresh PR against current master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][cli] Add generate-completion command to admin and client [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat closed pull request #22557: [improve][cli] Add generate-completion command to admin and client
URL: https://github.com/apache/pulsar/pull/22557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org