You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/03 00:53:10 UTC
[GitHub] [hudi] umehrot2 opened a new pull request #3383: [HUDI-2151] Enable defaults for out of box performance
umehrot2 opened a new pull request #3383:
URL: https://github.com/apache/hudi/pull/3383
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
Set better default to improve out of the box performance for Hudi. This so far does the following:
- Enable metadata table (for writers)
- Enable bulk insert using row writer
- Disable optimistic consistency guard
- Enable rollback using markers
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-959085263
@umehrot2 : we have already landed 6 to 8 defaults in last release. So, closing this out. If you have more, do put up a new patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] umehrot2 commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
umehrot2 commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-893072921
Put out a separate PR to enable metadata, as enabling some of these might be more involved https://github.com/apache/hudi/pull/3411 . Keeping this PR open, and will use this to enable the non-trivial defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-959085263
@umehrot2 : we have already landed 6 to 8 defaults in last release. So, closing this out. If you have more, do put up a new patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-897513723
Is this PR plan to be included in 0.9 release ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-891474910
> +1, there are many optimization options in hoodie and most of them are false, like the metadata table, i'm confused why.
Maybe, some features are marked the early beta label. They are experimental, will turn on as default behavior in the later version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] umehrot2 commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
umehrot2 commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-897992275
> Is this PR plan to be included in 0.9 release ?
@danny0405 If you are thinking specifically about metadata table, we will not be enabling it by default in Hudi 0.9.0. At this point, we are still seeing several test failures when enabling metadata https://github.com/apache/hudi/pull/3411/, and some of them are actual bugs. So, we have taken a call to stabilize this after Hudi 0.9.0, potentially in another minor release 0.9.1.
For other defaults, I think @nsivabalan has separate PRs put out to enable some of them. We will try to land whatever seem stable by tomorrow. cc @vinothchandar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan closed pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #3383:
URL: https://github.com/apache/hudi/pull/3383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-959085263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-891428716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1309",
"triggerID" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa321504eff0ee56a7fc0cf578f5743ef497af13 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1309)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-898767772
Removed from releasea-blocker in favor of https://github.com/apache/hudi/pull/3452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] umehrot2 commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
umehrot2 commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-893072921
Put out a separate PR to enable metadata, as enabling some of these might be more involved https://github.com/apache/hudi/pull/3411 . Keeping this PR open, and will use this to enable the non-trivial defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-891428716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1309",
"triggerID" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa321504eff0ee56a7fc0cf578f5743ef497af13 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1309)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-891428716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1309",
"triggerID" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa321504eff0ee56a7fc0cf578f5743ef497af13 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1309)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan closed pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #3383:
URL: https://github.com/apache/hudi/pull/3383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-891428716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa321504eff0ee56a7fc0cf578f5743ef497af13 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-897805154
@nsivabalan once your PR passes, we could close this in favor of that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3383:
URL: https://github.com/apache/hudi/pull/3383#issuecomment-891428716
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1309",
"triggerID" : "fa321504eff0ee56a7fc0cf578f5743ef497af13",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa321504eff0ee56a7fc0cf578f5743ef497af13 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1309)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan closed pull request #3383: [HUDI-2151] Enable defaults for out of box performance
Posted by GitBox <gi...@apache.org>.
nsivabalan closed pull request #3383:
URL: https://github.com/apache/hudi/pull/3383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org