[GitHub] [fineract] vidakovic commented on a change in pull request #1368: Improve error handling if reporting service implementation is missing [FINERACT-1173]

[GitBox <gi...@apache.org>]

vidakovic commented on a change in pull request #1368:
URL: https://github.com/apache/fineract/pull/1368#discussion_r528198871



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/api/RunreportsApiResource.java
##########
@@ -124,12 +125,13 @@ public Response runReport(@PathParam("reportName") @Parameter(description = "rep
             parameterTypeValue = "report";
             String reportType = this.readExtraDataAndReportingService.getReportType(reportName, isSelfServiceUserReport);
             ReportingProcessService reportingProcessService = this.reportingProcessServiceProvider.findReportingProcessService(reportType);
-            if (reportingProcessService != null) {
-                return reportingProcessService.processRequest(reportName, queryParams);
+            if (reportingProcessService == null) {
+                throw new PlatformServiceUnavailableException("err.msg.report.service.implementation.missing",
+                        ReportingProcessServiceProvider.SERVICE_MISSING + reportType, reportType);

Review comment:
       Also not sure how this SMS thing is supposed to work... will have a look at this later today.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org