[GitHub] [openwhisk] markusthoemmes commented on a change in pull request #4870: Calculate whether exist enough space more carefully

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #4870: Calculate whether exist enough space more carefully
URL: https://github.com/apache/openwhisk/pull/4870#discussion_r399976882
 
 

 ##########
 File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -119,7 +127,7 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
         }
         val createdContainer =
           // Is there enough space on the invoker for this action to be executed.
-          if (hasPoolSpaceFor(busyPool, r.action.limits.memory.megabytes.MB)) {
+          if (hasPoolSpaceFor(busyPool ++ prewarmedPoolForOtherKind, r.action.limits.memory.megabytes.MB)) {
 
 Review comment:
   I'd think we explicitly do not want to have the prewarm pool survive, if other actions would benefit from using that space. After all, it's a performance optimization, not a guarantee.
   
   Wouldn't this also be plumbed into the controller for it to not send requests down a path where they might not get executed?
   
   I think this warrants a dev-list discussion 🤔 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services