You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by markerickson-wf <gi...@git.apache.org> on 2016/01/29 22:29:18 UTC

[GitHub] thrift pull request: THRIFT-3589 Pass references to field names in...

GitHub user markerickson-wf opened a pull request:

    https://github.com/apache/thrift/pull/825

    THRIFT-3589 Pass references to field names in constructor through get_field_name

    Currently we are incorrectly handling fields that have default values and uppercase names, like `ID = -1`
    
    @stevenosborne-wf
    @ericklaus-wf
    @tylertreat-wf

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markerickson-wf/thrift thrift-3589

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #825
    
----
commit b490c74bea0243d027562f32cdb08f972bc99a50
Author: Mark Erickson <ma...@workiva.com>
Date:   2016-01-29T21:25:57Z

    Pass references to field names in constructor through get_field_name

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3589 Pass references to field names in...

Posted by stevenosborne-wf <gi...@git.apache.org>.
Github user stevenosborne-wf commented on the pull request:

    https://github.com/apache/thrift/pull/825#issuecomment-176984437
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3589 Pass references to field names in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/825


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---