You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/06/22 21:33:07 UTC

[GitHub] [zookeeper] anmolnar edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation

anmolnar edited a comment on issue #959: ZOOKEEPER-3402: Add multiRead operation
URL: https://github.com/apache/zookeeper/pull/959#issuecomment-504699768
 
 
   @lvfangmin I tend to agree with you from OOP perspective, but I think if we were to make this fully OOP compliant, the patch would be extremely large. As @szepet highlighted we would need to introduce more classes to make the distinction everywhere: MultiReadRead/MultiTxnRecord, ReadOp/TxnOp, MultiReadResponse/MultiTxnResponse, etc. I'm not sure about how large could it be.
   
   Personally I like this `OpKind` approach though I haven't come across with it in practice. Nice and easy. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services