[GitHub] [phoenix] gokceni commented on a change in pull request #1368: PHOENIX-6373 IndexRegionObserver changes for creating mutations for transforming t…

[GitBox <gi...@apache.org>]

gokceni commented on a change in pull request #1368:
URL: https://github.com/apache/phoenix/pull/1368#discussion_r774166025



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
##########
@@ -815,6 +819,18 @@ private void addIndexToTable(PName tenantId, PName schemaName, PName indexName,
         indexes.add(indexTable);
     }
 
+    private PTable getTransformingNewTable(PName tenantId, PName schemaName, PName tableName,
+                                           long clientTimeStamp, int clientVersion) throws IOException, SQLException {
+        byte[] tenantIdBytes = tenantId == null ? ByteUtil.EMPTY_BYTE_ARRAY : tenantId.getBytes();
+        PTable table = doGetTable(tenantIdBytes, schemaName.getBytes(), tableName.getBytes(), clientTimeStamp,
+                null, clientVersion);
+        if (table == null) {
+            ServerUtil.throwIOException("Transforming table not found", new TableNotFoundException(schemaName.getString(), tableName.getString()));
+            return null;

Review comment:
       Yes. Since java doesn't understand that it throws it every time, I put a return statement here. Will comment that it is impossible. Not needed though




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org