[jira] [Created] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

["Andrzej Bialecki (Jira)" <ji...@apache.org>]

Andrzej Bialecki created SOLR-16649:
---------------------------------------

             Summary: Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser
                 Key: SOLR-16649
                 URL: https://issues.apache.org/jira/browse/SOLR-16649
             Project: Solr
          Issue Type: Bug
      Security Level: Public (Default Security Level. Issues are Public)
          Components: clients - java
    Affects Versions: 9.1.1, main (10.0)
            Reporter: Andrzej Bialecki


`Http2SolrClient:800` calls `wantStream(...)` method but passes the wrong argument to it - instead of passing the local `processor` arg it uses the instance field `parser`.

Throughout this class there's a repeated pattern that easily leads to this confusion - in many methods a local var `parser` is created that overshadows the instance field, and then this local `parser` is passed around as argument to various operations. However, in this method the argument passed from the caller is named differently  (`processor`) and thus does not overshadow the instance field, which leads to this mistake.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org