You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/05/08 01:38:31 UTC
[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10339
Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
......................................................................
IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
---
M docs/topics/impala_invalidate_metadata.xml
1 file changed, 4 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/10339/1
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor tje INVALIDATE METADATA and REFRESH docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor tje INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 3:
The latest HTML docs were shared with Balazs and Dimitris.
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 May 2018 00:28:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 17:45:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 6:
This change did not cherrypick successfully into branch 2.x. To resolve this, please do the cherry-pick manually and submit it to Gerrit at refs/for/2.x or add an exception to the branch 2.x copy of bin/ignored_commits.json. Thanks, your friendly bot at https://jenkins.impala.io/job/cherrypick-2.x-and-test/607/ .
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Sun, 10 Jun 2018 10:26:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
Posted by "Balazs Jeszenszky (Code Review)" <ge...@cloudera.org>.
Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
......................................................................
Patch Set 1:
(18 comments)
IMO the page overall needs a wider cleanup, commented on that too.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml
File docs/topics/impala_invalidate_metadata.xml:
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@47
PS1, Line 47: relatively
replace: very
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@48
PS1, Line 48: in the common scenario of adding new data files to an existing table
replace: whenever possible (link to INVALIDATE vs. REFRESH usage page, if exists)
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@59
PS1, Line 59: By default
replace: If there is no table specified
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@60
PS1, Line 60: Even for a single table, <codeph>INVALIDATE METADATA</codeph> is more expensive
: than <codeph>REFRESH</codeph>, so prefer <codeph>REFRESH</codeph> in the common case where you add new data
: files for an existing table.
Same thing mentioned ~10 lines above - remove?
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@69
PS1, Line 69: Therefore, if some other entity modifies information used by Impala in the metastore
: that Impala and Hive share, the information cached by Impala must be updated. However, this does not mean
: that all metadata updates require an Impala update.
This is vague, explicitly state when is manual invalidate needed (see L100-102), and remove this.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@74
PS1, Line 74: <note>
: <p conref="../shared/impala_common.xml#common/catalog_server_124"/>
: <p rev="1.2">
: In Impala 1.2 and higher, a dedicated daemon (<cmdname>catalogd</cmdname>) broadcasts DDL changes made
: through Impala to all Impala nodes. Formerly, after you created a database or table while connected to one
: Impala node, you needed to issue an <codeph>INVALIDATE METADATA</codeph> statement on another Impala node
: before accessing the new database or table from the other node. Now, newly created or altered objects are
: picked up automatically by all Impala nodes. You must still use the <codeph>INVALIDATE METADATA</codeph>
: technique after creating or altering objects through Hive. See
: <xref href="impala_components.xml#intro_catalogd"/> for more information on the catalog service.
: </p>
: <p>
: The <codeph>INVALIDATE METADATA</codeph> statement is new in Impala 1.1 and higher, and takes over some of
: the use cases of the Impala 1.0 <codeph>REFRESH</codeph> statement. Because <codeph>REFRESH</codeph> now
: requires a table name parameter, to flush the metadata for all tables at once, use the <codeph>INVALIDATE
: METADATA</codeph> statement.
: </p>
: <p conref="../shared/impala_common.xml#common/invalidate_then_refresh"/>
: </note>
This section is very outdated and mixes up usage of old vs. new usage of REFRESH, remove.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@99
PS1, Line 99: instance
Don't mention individual instances in this context, it's the service as a whole that needs update.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@100
PS1, Line 100: required if a change is made from another <codeph>impalad</codeph>
: instance in your cluster, or through Hive and is distributed by
: <codeph>catalogd</codeph>.
INVALIDATE METADATA is required when:
* metadata changes of existing tables are done outside of Impala
* new tables are added outside of Impala, that are to be used by Impala
* SERVER or DATABASE level Sentry privileges are changed outside of Impala
* block metadata changes outside of Impala, but files remain the same (HDFS rebalance)
* possibly when UDF jars change (needs verification)
All metadata changes go through catalogd and are distributed by statestored.
'Outside of Impala' for table metadata means Hive and any other Hive client, e.g. SparkSQL.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@106
PS1, Line 106: same Impala node
This is pre-1.2 information. No INVALIDATE is needed as long as the changes are done through the Impala service (using any impalad).
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@127
PS1, Line 127: <codeph>INVALIDATE METADATA</codeph> causes the metadata for that table to be marked as stale, and reloaded
: the next time the table is referenced. For a huge table, that process could take a noticeable amount of time;
Repeat of L44-47
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@129
PS1, Line 129: thus you might prefer to use <codeph>REFRESH</codeph> where practical, to avoid an unpredictable delay later,
: for example if the next reference to the table is during a benchmark test.
Key information missing: use REFRESH after invalidating a specific table to separate the metadata load from the first query that's run against that table.
No need to mention this here IMO, remove.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@137
PS1, Line 137: (such as SequenceFile or HBase tables)
remove
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@139
PS1, Line 139: DESCRIBE
If L129-130 is left in, use REFRESH to make recommendation consistent.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@154
PS1, Line 154: <p conref="../shared/impala_common.xml#common/permissions_blurb"/>
: <p rev="">
: The user ID that the <cmdname>impalad</cmdname> daemon runs under,
: typically the <codeph>impala</codeph> user, must have execute
: permissions for all the relevant directories holding table data.
: (A table could have data spread across multiple directories,
: or in unexpected paths, if it uses partitioning or
: specifies a <codeph>LOCATION</codeph> attribute for
: individual partitions or the entire table.)
: Issues with permissions might not cause an immediate error for this statement,
: but subsequent statements such as <codeph>SELECT</codeph>
: or <codeph>SHOW TABLE STATS</codeph> could fail.
: </p>
Not specific to INVALIDATE, remove.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@171
PS1, Line 171: By default, the <codeph>INVALIDATE METADATA</codeph> command checks HDFS permissions of the underlying data
: files and directories, caching this information so that a statement can be cancelled immediately if for
: example the <codeph>impala</codeph> user does not have permission to write to the data directory for the
: table. (This checking does not apply when the <cmdname>catalogd</cmdname> configuration option
: <codeph>--load_catalog_in_background</codeph> is set to <codeph>false</codeph>, which it is by default.)
Sentence and bracketed part is contradictory, clarify.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@176
PS1, Line 176: Impala reports any lack of write permissions as an <codeph>INFO</codeph> message in the log file, in case
: that represents an oversight.
Is this INVALIDATE specific at all?
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@178
PS1, Line 178: INVALIDATE METADATA
Verify, wouldn't REFRESH do?
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@186
PS1, Line 186: The ability to specify <codeph>INVALIDATE METADATA
: <varname>table_name</varname></codeph> for a table created in Hive is a new capability in Impala 1.2.4. In
: earlier releases, that statement would have returned an error indicating an unknown table, requiring you to
: do <codeph>INVALIDATE METADATA</codeph> with no table name, a more expensive operation that reloaded metadata
: for all tables and databases.
Remove, already mentioned above.
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 May 2018 12:01:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
......................................................................
Patch Set 1:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml
File docs/topics/impala_invalidate_metadata.xml:
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@47
PS1, Line 47: relatively
> replace: very
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@48
PS1, Line 48: in the common scenario of adding new data files to an existing table
> replace: whenever possible (link to INVALIDATE vs. REFRESH usage page, if e
Replaced with "whenever possible" No link to add, though.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@59
PS1, Line 59: By default
> replace: If there is no table specified
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@60
PS1, Line 60: Even for a single table, <codeph>INVALIDATE METADATA</codeph> is more expensive
: than <codeph>REFRESH</codeph>, so prefer <codeph>REFRESH</codeph> in the common case where you add new data
: files for an existing table.
> Same thing mentioned ~10 lines above - remove?
Removed
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@69
PS1, Line 69: Therefore, if some other entity modifies information used by Impala in the metastore
: that Impala and Hive share, the information cached by Impala must be updated. However, this does not mean
: that all metadata updates require an Impala update.
> This is vague, explicitly state when is manual invalidate needed (see L100-
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@74
PS1, Line 74: <note>
: <p conref="../shared/impala_common.xml#common/catalog_server_124"/>
: <p rev="1.2">
: In Impala 1.2 and higher, a dedicated daemon (<cmdname>catalogd</cmdname>) broadcasts DDL changes made
: through Impala to all Impala nodes. Formerly, after you created a database or table while connected to one
: Impala node, you needed to issue an <codeph>INVALIDATE METADATA</codeph> statement on another Impala node
: before accessing the new database or table from the other node. Now, newly created or altered objects are
: picked up automatically by all Impala nodes. You must still use the <codeph>INVALIDATE METADATA</codeph>
: technique after creating or altering objects through Hive. See
: <xref href="impala_components.xml#intro_catalogd"/> for more information on the catalog service.
: </p>
: <p>
: The <codeph>INVALIDATE METADATA</codeph> statement is new in Impala 1.1 and higher, and takes over some of
: the use cases of the Impala 1.0 <codeph>REFRESH</codeph> statement. Because <codeph>REFRESH</codeph> now
: requires a table name parameter, to flush the metadata for all tables at once, use the <codeph>INVALIDATE
: METADATA</codeph> statement.
: </p>
: <p conref="../shared/impala_common.xml#common/invalidate_then_refresh"/>
: </note>
> This section is very outdated and mixes up usage of old vs. new usage of RE
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@99
PS1, Line 99: instance
> Don't mention individual instances in this context, it's the service as a w
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@100
PS1, Line 100: required if a change is made from another <codeph>impalad</codeph>
: instance in your cluster, or through Hive and is distributed by
: <codeph>catalogd</codeph>.
> INVALIDATE METADATA is required when:
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@106
PS1, Line 106: same Impala node
> This is pre-1.2 information. No INVALIDATE is needed as long as the changes
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@127
PS1, Line 127: <codeph>INVALIDATE METADATA</codeph> causes the metadata for that table to be marked as stale, and reloaded
: the next time the table is referenced. For a huge table, that process could take a noticeable amount of time;
> Repeat of L44-47
The whole paragraph is replaced.
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@129
PS1, Line 129: thus you might prefer to use <codeph>REFRESH</codeph> where practical, to avoid an unpredictable delay later,
: for example if the next reference to the table is during a benchmark test.
> Key information missing: use REFRESH after invalidating a specific table to
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@137
PS1, Line 137: (such as SequenceFile or HBase tables)
> remove
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@139
PS1, Line 139: DESCRIBE
> If L129-130 is left in, use REFRESH to make recommendation consistent.
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@154
PS1, Line 154: <p conref="../shared/impala_common.xml#common/permissions_blurb"/>
: <p rev="">
: The user ID that the <cmdname>impalad</cmdname> daemon runs under,
: typically the <codeph>impala</codeph> user, must have execute
: permissions for all the relevant directories holding table data.
: (A table could have data spread across multiple directories,
: or in unexpected paths, if it uses partitioning or
: specifies a <codeph>LOCATION</codeph> attribute for
: individual partitions or the entire table.)
: Issues with permissions might not cause an immediate error for this statement,
: but subsequent statements such as <codeph>SELECT</codeph>
: or <codeph>SHOW TABLE STATS</codeph> could fail.
: </p>
> Not specific to INVALIDATE, remove.
Done
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@176
PS1, Line 176: Impala reports any lack of write permissions as an <codeph>INFO</codeph> message in the log file, in case
: that represents an oversight.
> Is this INVALIDATE specific at all?
Removed
http://gerrit.cloudera.org:8080/#/c/10339/1/docs/topics/impala_invalidate_metadata.xml@186
PS1, Line 186: The ability to specify <codeph>INVALIDATE METADATA
: <varname>table_name</varname></codeph> for a table created in Hive is a new capability in Impala 1.2.4. In
: earlier releases, that statement would have returned an error indicating an unknown table, requiring you to
: do <codeph>INVALIDATE METADATA</codeph> with no table name, a more expensive operation that reloaded metadata
: for all tables and databases.
> Remove, already mentioned above.
Done
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 May 2018 23:00:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 18:18:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
......................................................................
Patch Set 2:
The newly generated google doc is shared with you. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 May 2018 23:06:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10339/4/docs/topics/impala_refresh.xml
File docs/topics/impala_refresh.xml:
http://gerrit.cloudera.org:8080/#/c/10339/4/docs/topics/impala_refresh.xml@52
PS4, Line 52: Name Nodes
> Don't remember how docs reference this but let's make sure the naming is co
Corrected to NameNodes
http://gerrit.cloudera.org:8080/#/c/10339/4/docs/topics/impala_refresh.xml@111
PS4, Line 111: Creating or updating functions
> Perhaps its easier to split REFRESH from REFRESH FUNCTIONS on L72-3 into se
Created a separate doc for REFRESH FUNCTIONS
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 18:39:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Balazs Jeszenszky, Alex Behm, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10339
to look at the new patch set (#4).
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
---
M docs/shared/impala_common.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_refresh.xml
3 files changed, 269 insertions(+), 415 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/10339/4
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/313/
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 18:15:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Balazs Jeszenszky, Dimitris Tsirogiannis, Alex Behm, Impala Public Jenkins, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10339
to look at the new patch set (#5).
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_refresh.xml
A docs/topics/impala_refresh_functions.xml
5 files changed, 343 insertions(+), 418 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/10339/5
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 5:
Hi Vuk,
Could you review the latest patch that addressed your comments?
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 20:39:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor tje INVALIDATE METADATA and REFRESH docs
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Balazs Jeszenszky, Alex Behm, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10339
to look at the new patch set (#3).
Change subject: IMPALA-6987: [DOCS] Refactor tje INVALIDATE METADATA and REFRESH docs
......................................................................
IMPALA-6987: [DOCS] Refactor tje INVALIDATE METADATA and REFRESH docs
Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
---
M docs/shared/impala_common.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_refresh.xml
3 files changed, 269 insertions(+), 415 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/10339/3
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Reviewed-on: http://gerrit.cloudera.org:8080/10339
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/impala.ditamap
M docs/shared/impala_common.xml
M docs/topics/impala_invalidate_metadata.xml
M docs/topics/impala_refresh.xml
A docs/topics/impala_refresh_functions.xml
5 files changed, 343 insertions(+), 418 deletions(-)
Approvals:
Vuk Ercegovac: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10339/4/docs/topics/impala_refresh.xml
File docs/topics/impala_refresh.xml:
http://gerrit.cloudera.org:8080/#/c/10339/4/docs/topics/impala_refresh.xml@52
PS4, Line 52: Name Nodes
Don't remember how docs reference this but let's make sure the naming is consistent.
http://gerrit.cloudera.org:8080/#/c/10339/4/docs/topics/impala_refresh.xml@111
PS4, Line 111: Creating or updating functions
Functions are under databases not tables. Hence, when functions are created or update you need to run refresh database not refresh table.
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 04:59:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 4:
Sorry for the delay. Taking a look today.
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 May 2018 15:40:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
......................................................................
Patch Set 1:
Balazs,
Could you please review this?
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 May 2018 19:40:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Balazs Jeszenszky, Alex Behm, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10339
to look at the new patch set (#2).
Change subject: IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
......................................................................
IMPALA-6987: [DOCS] Update when INVALIDATE METADATA is required
Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
---
M docs/shared/impala_common.xml
M docs/topics/impala_invalidate_metadata.xml
2 files changed, 133 insertions(+), 149 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/10339/2
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10339 )
Change subject: IMPALA-6987: [DOCS] Refactor the INVALIDATE METADATA and REFRESH docs
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10339/4/docs/topics/impala_refresh.xml
File docs/topics/impala_refresh.xml:
http://gerrit.cloudera.org:8080/#/c/10339/4/docs/topics/impala_refresh.xml@111
PS4, Line 111: Creating or updating functions
> Functions are under databases not tables. Hence, when functions are created
Perhaps its easier to split REFRESH from REFRESH FUNCTIONS on L72-3 into separate sections so that its clear that mentions of "table" refers to REFRESH and not REFRESH FUNCTIONS.
--
To view, visit http://gerrit.cloudera.org:8080/10339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2124e14900d0f82569c061cc46006447bb054b36
Gerrit-Change-Number: 10339
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Balazs Jeszenszky <je...@gmail.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 06:31:07 +0000
Gerrit-HasComments: Yes