You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Tim McConnell (JIRA)" <ji...@apache.org> on 2009/05/15 19:11:45 UTC
[jira] Created: (OPENJPA-1090) Oracle failures due to the following
warning "This database dictionary "Oracle" does not support auto-assigned
column values. The column "pid" may not behave as desired."
Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Key: OPENJPA-1090
URL: https://issues.apache.org/jira/browse/OPENJPA-1090
Project: OpenJPA
Issue Type: Sub-task
Reporter: Tim McConnell
Assignee: Tim McConnell
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1090) Oracle failures due to the
following warning "This database dictionary "Oracle" does not support
auto-assigned column values. The column "pid" may not behave as desired."
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712211#action_12712211 ]
Tim McConnell commented on OPENJPA-1090:
----------------------------------------
Thanks much for reviewing Donald. I'll investigate and change accordingly.....
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1090) Oracle failures due to the following
warning "This database dictionary "Oracle" does not support auto-assigned
column values. The column "pid" may not behave as desired."
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-1090:
-----------------------------------
Attachment: OPENJPA-1090_3.patch
Attaching smaller patch incorporating Milosz's comments.....
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090_2.patch, OPENJPA-1090_3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1090) Oracle failures due to the following
warning "This database dictionary "Oracle" does not support auto-assigned
column values. The column "pid" may not behave as desired."
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-1090:
-----------------------------------
Attachment: OPENJPA-1090.patch
This patch will check to ensure that the database supports auto-assign column(s) before attempting to use Entities with this annotation::
@GeneratedValue(strategy=GenerationType.IDENTITY)
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1090) Oracle failures due to the following
warning "This database dictionary "Oracle" does not support auto-assigned
column values. The column "pid" may not behave as desired."
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Donald Woods updated OPENJPA-1090:
----------------------------------
Patch Info: [Patch Available]
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1090) Oracle failures due to the
following warning "This database dictionary "Oracle" does not support
auto-assigned column values. The column "pid" may not behave as desired."
Posted by "Milosz Tylenda (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712382#action_12712382 ]
Milosz Tylenda commented on OPENJPA-1090:
-----------------------------------------
Hi Tim & Donald. If I can have a remark I would suggest that the code will be more readable and the patch much smaller if instead of:
testMethod() {
if (supportsAutoAssign) {
[method body]
}
}
we do:
testMethod() {
if (!supportsAutoAssign) {
return;
}
[method body]
}
This is how, for example, TestGenerationType does it (which, BTW, does not need to be modified by the patch)
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1090) Oracle failures due to the
following warning "This database dictionary "Oracle" does not support
auto-assigned column values. The column "pid" may not behave as desired."
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712454#action_12712454 ]
Tim McConnell commented on OPENJPA-1090:
----------------------------------------
Hi Milosz, Not sure I agree or not since I tend to prefer single return points from methods (when possible), but I do see and appreciate your point. So, what I'll do is add another patch doing as you suggest and let whomever commits the patch be the final arbiter ;-)
Thanks much for reviewing.....
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1090) Oracle failures due to the following
warning "This database dictionary "Oracle" does not support auto-assigned
column values. The column "pid" may not behave as desired."
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-1090:
-----------------------------------
Attachment: (was: OPENJPA-1090.patch)
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-1090) Oracle failures due to the
following warning "This database dictionary "Oracle" does not support
auto-assigned column values. The column "pid" may not behave as desired."
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell resolved OPENJPA-1090.
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.0.0
>
> Attachments: OPENJPA-1090_2.patch, OPENJPA-1090_3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (OPENJPA-1090) Oracle failures due to the
following warning "This database dictionary "Oracle" does not support
auto-assigned column values. The column "pid" may not behave as desired."
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on OPENJPA-1090 started by Tim McConnell.
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1090) Oracle failures due to the
following warning "This database dictionary "Oracle" does not support
auto-assigned column values. The column "pid" may not behave as desired."
Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710368#action_12710368 ]
Donald Woods commented on OPENJPA-1090:
---------------------------------------
Tim, can you use the existing DBDictionary.supportsAutoAssign boolean instead of the try/catch block in setup(), or is it not getting set correctly for Oracle?
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1090) Oracle failures due to the following
warning "This database dictionary "Oracle" does not support auto-assigned
column values. The column "pid" may not behave as desired."
Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated OPENJPA-1090:
-----------------------------------
Attachment: OPENJPA-1090_2.patch
Second patch has been attached after incorporating Donald's comments.....
> Oracle failures due to the following warning "This database dictionary "Oracle" does not support auto-assigned column values. The column "pid" may not behave as desired."
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OPENJPA-1090
> URL: https://issues.apache.org/jira/browse/OPENJPA-1090
> Project: OpenJPA
> Issue Type: Sub-task
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Attachments: OPENJPA-1090_2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.