[GitHub] [hbase] ndimiduk commented on a diff in pull request #5035: HBASE-27651 hbase-daemon.sh foreground_start should propagate SIGHUP and SIGTERM

["ndimiduk (via GitHub)" <gi...@apache.org>]

ndimiduk commented on code in PR #5035:
URL: https://github.com/apache/hbase/pull/5035#discussion_r1140465808


##########
bin/hbase-daemon.sh:
##########
@@ -78,22 +78,33 @@ hbase_rotate_log ()
     fi
 }
 
-cleanAfterRun() {
-  if [ -f ${HBASE_PID} ]; then
-    # If the process is still running time to tear it down.
-    kill -9 `cat ${HBASE_PID}` > /dev/null 2>&1
-    rm -f ${HBASE_PID} > /dev/null 2>&1
+function sighup_handler
+{
+  # pass through SIGHUP if we can
+  if [ -f "${HBASE_PID}" ] ; then
+    kill -s HUP "$(cat "${HBASE_PID}")"

Review Comment:
   Testing in a docker container that disappears... I'm guessing that this script already handles the pid file, but let me look more closely...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org