You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:47:52 UTC
[GitHub] [plc4x] hutcheb opened a new pull request #200: PLC4X-255 Fix for Kafka Source CPU Usage
hutcheb opened a new pull request #200:
URL: https://github.com/apache/plc4x/pull/200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] ottobackwards merged pull request #200: PLC4X-255 Fix for Kafka Source CPU Usage
Posted by GitBox <gi...@apache.org>.
ottobackwards merged pull request #200:
URL: https://github.com/apache/plc4x/pull/200
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] hutcheb commented on a change in pull request #200: PLC4X-255 Fix for Kafka Source CPU Usage
Posted by GitBox <gi...@apache.org>.
hutcheb commented on a change in pull request #200:
URL: https://github.com/apache/plc4x/pull/200#discussion_r517294440
##########
File path: plc4j/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSourceTask.java
##########
@@ -219,7 +220,13 @@ public void stop() {
buffer.drainTo(result, numElements);
return result;
} else {
Review comment:
Well that took longer than I thought it would.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] ottobackwards commented on a change in pull request #200: PLC4X-255 Fix for Kafka Source CPU Usage
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #200:
URL: https://github.com/apache/plc4x/pull/200#discussion_r516711853
##########
File path: plc4j/integrations/apache-kafka/src/main/java/org/apache/plc4x/kafka/Plc4xSourceTask.java
##########
@@ -219,7 +220,13 @@ public void stop() {
buffer.drainTo(result, numElements);
return result;
} else {
Review comment:
Is there some way to make these configurable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org