You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/06 20:40:18 UTC
Review Request 16654: Replaced 'std::tr1' with 'lambda' and 'memory' in
stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16654/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Repository: mesos-git
Description
-------
The 'lambda' and 'memory' namespace gives us a level-of-indirection that makes it easier to do either C++03 or C++11 compilation.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 653507c5f1293acb929d2ffa33738fd830541c84
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2ba739de44be816fa7b855d2ae8e9edb59d0210a
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 0d3c836e3aec04c87bbfad1a0fd8513241db9e86
3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp a6e0f58f5291f12609c8807711432209f1eea117
3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 4c5b29714ca863afc540620ba14334e2fc6421ca
3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp 669218c7b8bcbea5ae6731df4a769bbb444681eb
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp cae7fcb5c617e830018bbfde01e37d609d5bb094
3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45
3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 838a5fea504261831b9fe2103aba965528ea5e39
Diff: https://reviews.apache.org/r/16654/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 16654: Replaced 'std::tr1' with 'lambda' and 'memory' in
stout.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16654/#review31641
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16654/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'lambda' and 'memory' namespace gives us a level-of-indirection that makes it easier to do either C++03 or C++11 compilation.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 653507c5f1293acb929d2ffa33738fd830541c84
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2ba739de44be816fa7b855d2ae8e9edb59d0210a
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 0d3c836e3aec04c87bbfad1a0fd8513241db9e86
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp a6e0f58f5291f12609c8807711432209f1eea117
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 4c5b29714ca863afc540620ba14334e2fc6421ca
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp 669218c7b8bcbea5ae6731df4a769bbb444681eb
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp cae7fcb5c617e830018bbfde01e37d609d5bb094
> 3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45
> 3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 838a5fea504261831b9fe2103aba965528ea5e39
>
> Diff: https://reviews.apache.org/r/16654/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 16654: Replaced 'std::tr1' with 'lambda' and 'memory' in
stout.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16654/#review31558
-----------------------------------------------------------
Ship it!
Ship it, modulo the needed Makefile.am fix.
3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp
<https://reviews.apache.org/r/16654/#comment60083>
Could this be <stout/hashmap.hpp>?
- Ben Mahler
On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16654/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'lambda' and 'memory' namespace gives us a level-of-indirection that makes it easier to do either C++03 or C++11 compilation.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 653507c5f1293acb929d2ffa33738fd830541c84
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2ba739de44be816fa7b855d2ae8e9edb59d0210a
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 0d3c836e3aec04c87bbfad1a0fd8513241db9e86
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp a6e0f58f5291f12609c8807711432209f1eea117
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 4c5b29714ca863afc540620ba14334e2fc6421ca
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp 669218c7b8bcbea5ae6731df4a769bbb444681eb
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp cae7fcb5c617e830018bbfde01e37d609d5bb094
> 3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45
> 3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 838a5fea504261831b9fe2103aba965528ea5e39
>
> Diff: https://reviews.apache.org/r/16654/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 16654: Replaced 'std::tr1' with 'lambda' and 'memory' in
stout.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Jan. 8, 2014, 2:36 a.m., Ben Mahler wrote:
> > Are you missing a Makefile change for your new file?
Yes, thank you!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16654/#review31334
-----------------------------------------------------------
On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16654/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'lambda' and 'memory' namespace gives us a level-of-indirection that makes it easier to do either C++03 or C++11 compilation.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 653507c5f1293acb929d2ffa33738fd830541c84
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2ba739de44be816fa7b855d2ae8e9edb59d0210a
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 0d3c836e3aec04c87bbfad1a0fd8513241db9e86
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp a6e0f58f5291f12609c8807711432209f1eea117
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 4c5b29714ca863afc540620ba14334e2fc6421ca
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp 669218c7b8bcbea5ae6731df4a769bbb444681eb
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp cae7fcb5c617e830018bbfde01e37d609d5bb094
> 3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45
> 3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 838a5fea504261831b9fe2103aba965528ea5e39
>
> Diff: https://reviews.apache.org/r/16654/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 16654: Replaced 'std::tr1' with 'lambda' and 'memory' in
stout.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16654/#review31334
-----------------------------------------------------------
Are you missing a Makefile change for your new file?
- Ben Mahler
On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16654/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 7:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The 'lambda' and 'memory' namespace gives us a level-of-indirection that makes it easier to do either C++03 or C++11 compilation.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 653507c5f1293acb929d2ffa33738fd830541c84
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2ba739de44be816fa7b855d2ae8e9edb59d0210a
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 0d3c836e3aec04c87bbfad1a0fd8513241db9e86
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp a6e0f58f5291f12609c8807711432209f1eea117
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 4c5b29714ca863afc540620ba14334e2fc6421ca
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp 669218c7b8bcbea5ae6731df4a769bbb444681eb
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp cae7fcb5c617e830018bbfde01e37d609d5bb094
> 3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp d493353838d95eb2698892a97c5440190a015c45
> 3rdparty/libprocess/3rdparty/stout/include/stout/memory.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 838a5fea504261831b9fe2103aba965528ea5e39
>
> Diff: https://reviews.apache.org/r/16654/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>