You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pig.apache.org by "Jonathan Coveney (JIRA)" <ji...@apache.org> on 2012/10/22 20:20:13 UTC

[jira] [Commented] (PIG-2881) Add SUBTRACT eval function

    [ https://issues.apache.org/jira/browse/PIG-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481575#comment-13481575 ] 

Jonathan Coveney commented on PIG-2881:
---------------------------------------

Joel,

This looks fine, but for the final oomph, can you do the following:
- Put it in Pig w/the proper package (either org.apache.pig.builtin or the Piggybank)
- Generate a diff against trunk

This will make it so people can download and see exactly what is being applied. We like to avoid cases where many steps need to be taken to exactly replicate what is in trunk.

Thanks for contributing
Jon
                
> Add SUBTRACT eval function
> --------------------------
>
>                 Key: PIG-2881
>                 URL: https://issues.apache.org/jira/browse/PIG-2881
>             Project: Pig
>          Issue Type: New Feature
>          Components: piggybank
>    Affects Versions: 0.10.0
>            Reporter: Joel Costigliola
>            Priority: Minor
>         Attachments: Subtract.java, SubtractTest.java
>
>
> Close to DIFF function but SUBTRACT(bag1, bag2) will subtract elements of bag2 from bag1.
>   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira