You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/01 05:36:46 UTC
[GitHub] [arrow-datafusion] pjmore opened a new pull request #230: Count distinct boolean
pjmore opened a new pull request #230:
URL: https://github.com/apache/arrow-datafusion/pull/230
# Which issue does this PR close?
Closes #202 .
# What changes are included in this PR?
Modified the method to_array_of_size from ScalarValue to add support for boolean lists.
# Are there any user-facing changes?
I don't believe so, I couldn't find any relevant documentation about supported datatypes for COUNT DISTINCT but I'm not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #230: Count distinct boolean
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #230:
URL: https://github.com/apache/arrow-datafusion/pull/230#issuecomment-830635876
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#230](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e48830) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/23d02bb3c642ed69e7b963ed74df9687b91af970?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23d02bb) will **increase** coverage by `0.04%`.
> The diff coverage is `97.29%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 76.46% 76.50% +0.04%
==========================================
Files 135 135
Lines 23250 23287 +37
==========================================
+ Hits 17777 17815 +38
+ Misses 5473 5472 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tafusion/src/physical\_plan/distinct\_expressions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvcGh5c2ljYWxfcGxhbi9kaXN0aW5jdF9leHByZXNzaW9ucy5ycw==) | `91.32% <97.22%> (+1.03%)` | :arrow_up: |
| [datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvc2NhbGFyLnJz) | `54.14% <100.00%> (+0.11%)` | :arrow_up: |
| [datafusion/src/physical\_plan/group\_scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvcGh5c2ljYWxfcGxhbi9ncm91cF9zY2FsYXIucnM=) | `57.64% <0.00%> (+2.35%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [23d02bb...9e48830](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #230: Count distinct boolean
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #230:
URL: https://github.com/apache/arrow-datafusion/pull/230#issuecomment-830580876
@pjmore looks good! Maybe you could also add a test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #230: Count distinct boolean
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #230:
URL: https://github.com/apache/arrow-datafusion/pull/230#issuecomment-830635876
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#230](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e1114cb) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/23d02bb3c642ed69e7b963ed74df9687b91af970?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23d02bb) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #230 +/- ##
=======================================
Coverage 76.46% 76.46%
=======================================
Files 135 135
Lines 23250 23251 +1
=======================================
+ Hits 17777 17778 +1
Misses 5473 5473
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/230/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcmMvc2NhbGFyLnJz) | `54.14% <100.00%> (+0.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [23d02bb...e1114cb](https://codecov.io/gh/apache/arrow-datafusion/pull/230?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #230: Count distinct boolean
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #230:
URL: https://github.com/apache/arrow-datafusion/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] pjmore commented on pull request #230: Count distinct boolean
Posted by GitBox <gi...@apache.org>.
pjmore commented on pull request #230:
URL: https://github.com/apache/arrow-datafusion/pull/230#issuecomment-830685441
@Dandandan I've added a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #230: Count distinct boolean
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #230:
URL: https://github.com/apache/arrow-datafusion/pull/230#issuecomment-830798163
@pjmore could you fix the clippy error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan edited a comment on pull request #230: Count distinct boolean
Posted by GitBox <gi...@apache.org>.
Dandandan edited a comment on pull request #230:
URL: https://github.com/apache/arrow-datafusion/pull/230#issuecomment-830798163
@pjmore thanks! Could you fix the clippy error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org