You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/11 15:29:02 UTC

[GitHub] [pulsar] nodece opened a new pull request #14243: [Broker] Fix NPE of internalExpireMessagesByTimestamp

nodece opened a new pull request #14243:
URL: https://github.com/apache/pulsar/pull/14243


   ### Motivation
   
   This issue was triggered by #13880, it doesn't handle the NPE in [here](https://github.com/apache/pulsar/pull/13880/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1R3502), we can check the [diff code](https://github.com/apache/pulsar/pull/13880/files#diff-66aeb65a64cbe7c541f013ae807c5bcbeab567bef77706c7ff2e0cbfe0d77eb1L3489) in #13880.
   
   /cc @liudezhi2098 
   
   ### Modifications
   
   - Use `if` instead of `checkNotNull`
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   ### Documentation
     
   - [x] `no-need-doc` - Fix the code 
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #14243: [Broker] Fix NPE of internalExpireMessagesByTimestamp

Posted by GitBox <gi...@apache.org>.

lhotari commented on pull request #14243:
URL: https://github.com/apache/pulsar/pull/14243#issuecomment-1038719641


   @codelipenghui @merlimat @Technoboy- @mattisonchao   Why are the sync -> async changes made just before 2.10.0 release? This introduces new bugs as we can see once again. This bug fix is needed since #13880 introduced a new bug. 
   This is not the only case. I hope that this gets followed up on the dev mailing list asap. 
   https://github.com/apache/pulsar/issues/14013#issuecomment-1033528348
   https://github.com/apache/pulsar/pull/14163#issuecomment-1033519034
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #14243: [Broker] Fix NPE of internalExpireMessagesByTimestamp

Posted by GitBox <gi...@apache.org>.

codelipenghui merged pull request #14243:
URL: https://github.com/apache/pulsar/pull/14243


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org