[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6492: NIFI-10604 - Added idle connection timeout property to ListenTCP. Tes…

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6492:
URL: https://github.com/apache/nifi/pull/6492#discussion_r990205077


##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenTCP.java:
##########
@@ -133,6 +135,15 @@ public class ListenTCP extends AbstractProcessor {
             .addValidator(StandardValidators.BOOLEAN_VALIDATOR)
             .build();
 
+    protected static final PropertyDescriptor IDLE_CONNECTION_TIMEOUT = new PropertyDescriptor.Builder()
+            .name("idle-timeout")
+            .displayName("Idle Connection Timeout")
+            .description("The amount of time a client's connection will remain open if no data is received. The default of 0 seconds will leave connections open until they are closed by the client.")
+            .required(false)

Review Comment:
   With the default value matching current behavior, it looks like `required` should be `true`, which might also warrant adjusting the order of the property.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org