[GitHub] [incubator-kvrocks] vmihailenco commented on a diff in pull request #899: test: harden quit_test and list_test

[GitBox <gi...@apache.org>]

vmihailenco commented on code in PR #899:
URL: https://github.com/apache/incubator-kvrocks/pull/899#discussion_r978665051


##########
tests/gocase/unit/type/list/list_test.go:
##########
@@ -93,7 +94,7 @@ func TestZipList(t *testing.T) {
 	defer srv.Close()
 	ctx := context.Background()
 	rdb := srv.NewClientWithOption(&redis.Options{
-		MaxRetries: -1,
+		ReadTimeout: 10 * time.Second,

Review Comment:
   Yes, this seems worth a try. The default is 3 seconds.
   
   In go-redis tests we also have a busy loop to wait until Redis Server is fully bootstrapped, but I am not sure whether it is needed for kvrocks:
   
   ```go
   for i := 0; i < 100; i++ {
     if err := rdb.Ping().Err(); err != nil {
       time.Sleep(100*time.Millisecond)
       continue
     }
     break
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org