[GitHub] spark pull request #21403: [SPARK-24341][SQL] Support only IN subqueries wit...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21403#discussion_r207701506
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala ---
    @@ -505,6 +505,7 @@ object NullPropagation extends Rule[LogicalPlan] {
     
           // If the value expression is NULL then transform the In expression to null literal.
           case In(Literal(null, _), _) => Literal.create(null, BooleanType)
    +      case InSubquery(Seq(Literal(null, _)), _) => Literal.create(null, BooleanType)
    --- End diff --
    
    Thanks for adding this! Please double check all the cases of `IN` in all the optimizer rules. We are afraid this new expression might introduce a regression. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org