Re: [PR] feat(FQDN): Replace rpc_address to host_prot for function & Add host_port on thrift struct [incubator-pegasus]

["GehaFearless (via GitHub)" <gi...@apache.org>]

GehaFearless commented on code in PR #1658:
URL: https://github.com/apache/incubator-pegasus/pull/1658#discussion_r1382871191


##########
src/client/partition_resolver.cpp:
##########
@@ -124,7 +127,7 @@ void partition_resolver::call_task(const rpc_response_task_ptr &t)
                     }
                     hdr.gpid = result.pid;
                 }
-                dsn_rpc_call(result.address, t.get());
+                dsn_rpc_call(this->_dns_resolver->resolve_address(result.hp), t.get());

Review Comment:
   Coz of design before, all of `dsn_rpc_call` shound be use host_port by `resolve_address.`
   It will be performance problem, How could I improve it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org