[jira] Updated: (XERCESC-1343) SAX2XMLReaderImpl performance improvement

["David Bertoni (JIRA)" <xe...@xml.apache.org>]

     [ http://issues.apache.org/jira/browse/XERCESC-1343?page=history ]

David Bertoni updated XERCESC-1343:
-----------------------------------

    Attachment: patch.txt

Suggested patch.

> SAX2XMLReaderImpl performance improvement
> -----------------------------------------
>
>          Key: XERCESC-1343
>          URL: http://issues.apache.org/jira/browse/XERCESC-1343
>      Project: Xerces-C++
>         Type: Improvement
>   Components: SAX/SAX2
>     Versions: 2.6.0
>  Environment: all
>     Reporter: David Bertoni
>  Attachments: patch.txt
>
> When doing namespace-aware parsing, the startElement() and endElement() events construct the QName parameter when the value is already available.
> I am submitting a proposed patch, which also removes an unecessary cast, an now-unused data member, and narrows the scope of two variables.
> One additional point that I did not want to address with this patch is whether or not these two if conditions are exclusive:
>                 if (XMLString::equals(tempAttr->getQName(), nsString))
>                     nsURI = tempAttr->getValue();
>                 if (XMLString::equals(tempAttr->getPrefix(), nsString))
> I believe they are, since the QName and the prefix can never be equal, but I was not 100% sure.  If the are, then this can be modified to:
>                 if (XMLString::equals(tempAttr->getQName(), nsString))
>                     nsURI = tempAttr->getValue();
>                 else if (XMLString::equals(tempAttr->getPrefix(), nsString))

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xerces-c-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xerces-c-dev-help@xml.apache.org