You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by anagav <gi...@git.apache.org> on 2015/10/16 06:20:17 UTC
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
GitHub user anagav opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/109
Use Epoll based netty eventloop when possible
This patch checks if the the OS is linux and uses netty epoll based event loops which perform better than NIO based event loops.
More details at:
http://netty.io/wiki/native-transports.html
Not sure if you guys have already tried it out. I saw a reduced GC pressure using epoll.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anagav/incubator-tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit f0d39fdaab3cc5064a99801fcfc5d6ede7f37911
Author: ashishn <as...@yahoo-inc.com>
Date: 2015-10-16T04:10:12Z
use epollbased event loops when possible
commit b611bc6018da36fc6f249e3b630cf0fff0fedcd3
Author: ashishn <as...@yahoo-inc.com>
Date: 2015-10-16T04:11:03Z
use epollbased event loops when possible
commit 6ab524f0afcded08760f79e027eb1e4539725973
Author: ashishn <as...@yahoo-inc.com>
Date: 2015-10-16T04:11:41Z
fix imports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149196287
This is shaping up into a nice PR. You probably expected to get to this last, but just as a reminder, the docs need to be updated as well with your new configuration option: `useEpollEventLoop`. Please add it to the table here:
https://github.com/apache/incubator-tinkerpop/blob/master/docs/src/gremlin-applications.asciidoc#configuring
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-150203705
Thanks @anagav - nice PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#discussion_r42361719
--- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java ---
@@ -71,21 +74,33 @@
private final EventLoopGroup workerGroup;
private final ExecutorService gremlinExecutorService;
private final ServerGremlinExecutor<EventLoopGroup> serverGremlinExecutor;
+ private final boolean isLinuxOS;
/**
* Construct a Gremlin Server instance from {@link Settings}.
*/
public GremlinServer(final Settings settings) {
this.settings = settings;
+ this.isLinuxOS = settings.useEpollEventLoop && SystemUtils.IS_OS_LINUX;
--- End diff --
minor nit....can you please rename `isLinuxOS` to something more fitting, like `epollEnabled`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149542631
Created an issue to track this against:
https://issues.apache.org/jira/browse/TINKERPOP3-901
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148669927
I did want to try this out. Nice to know that you saw positive improvement for doing so. Did you happen to run the gremlin-server integration tests on your end to make sure everything works nice there?
```text
mvn clean install
cd gremlin-server
mvn verify -DskipIntegrationTests=false
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by anagav <gi...@git.apache.org>.
Github user anagav commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149423156
@spmallette I have updated the doc :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-150193321
Reviewed the code. Tested with and without EPOLL on Linux, tested on non-Linux platforms also.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by anagav <gi...@git.apache.org>.
Github user anagav commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149047789
@spmallette I have added code based on your comments.
* I have added maven profile activation based on os
* enable the setting in `AbstractGremlinServerIntegrationTest`
* use this setting while running test to use epoll (if not present fallback to NIO).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by mhfrantz <gi...@git.apache.org>.
Github user mhfrantz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148776098
@anagav We currently use Apache's Jenkins resources, but we don't have it working exactly the way we want it to. If you have Travis know-how, then that would work. I believe there was once a working Travis CI, at least for unit tests. The goal would be to run integration tests in the CI, too. If we start doing platform-specific things on purpose (or in case we do so accidentally), then we should cover that with the CI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by anagav <gi...@git.apache.org>.
Github user anagav commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148815587
@spmallette I have already added (first commit :) ) a variable in Settings class which can be overwritten from the config file.
The setting looks like:
`
+ public boolean useEpollEventLoop = false;
`
So the decision to use epollevent loop would be `epollSettingEnabled && IS_OS_LINUX` .
Adding a profile based test sounds good to me. I will try to get it done over weekend and hopefully should have something monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148816173
Sounds like a good start and glad you agree with the approach. Thanks for going the extra step with this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#discussion_r42359095
--- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java ---
@@ -99,11 +114,16 @@ public GremlinServer(final Settings settings) {
public GremlinServer(final ServerGremlinExecutor<EventLoopGroup> serverGremlinExecutor) {
this.serverGremlinExecutor = serverGremlinExecutor;
this.settings = serverGremlinExecutor.getSettings();
+ this.isLinuxOS = settings.useEpollEventLoop && SystemUtils.IS_OS_LINUX;
--- End diff --
I think that it would be worth doing a `logger.warn()` after this line if someone tries to "useEpoll" but are not on linux. I'd further add a `logger.info()` to indicate the event loop ultimately used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149652503
VOTE: +1
This PR feels ready for general review from committers. Here's a summary for those who haven't been following along:
* The PR adds a configuration to Gremlin Server to use a linux-only netty feature that has shown to improve performance.
* @anagav was good enough to work tests such that we can run Gremlin Server integration tests with and without this feature by way of a secondary maven profile. In this way we can run tests on any platform.
From my testing perspective, I successfully did:
```text
mvn clean install
cd gremlin-server
mvn verify -DskipIntegrationTests=false
mvn verify -DskipIntegrationTests=false -Plinux
```
Even if you're not testing on linux it would be good to try the `-Plinux` option as it will validate the fallback to java NIO and still work.
I'll handle the merge of this PR (when the VOTE is complete) and update changelog in the process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by pluradj <gi...@git.apache.org>.
Github user pluradj commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#discussion_r42674763
--- Diff: gremlin-server/pom.xml ---
@@ -148,6 +149,30 @@ limitations under the License.
</build>
<profiles>
<profile>
+ <id>linux</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ <property>
+ <name>EPOLL</name>
--- End diff --
Should add a note in the contributing doc about the `EPOLL` profile, similar to `includeNeo4j` https://github.com/apache/incubator-tinkerpop/blob/master/CONTRIBUTING.asciidoc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148778506
> It makes sense to to have separate tests for linux and non-linux env to get coverage of using epoll event loops. Let me work on that.
Do you have a sense of how you want to implement that?
> Also maybe have a travis setup to run tests on multiple platforms.
There are some issues with using travis in the full way we would like. I suppose if we restricted travis to just:
```text
mvn clean install
cd gremlin-server
mvn verify -DskipIntegrationTests=false
```
The build would likely not time out. But we couldn't run the full integration suite over the entire project. I think it takes too long.
> also will it be helpful to have travis build for the project? if so I can set it up.
@anagav thank you for offering. :)
@mhfrantz think you could work with @anagav on something here? i know you've been thinking about our CI situtation. I ask because he'll need some help navigating apache infra with whatever we come up with. btw, that discussion should probably happen on the dev mailing list and not here. @anagav are you on our dev mailing list? if not, it would be great if you could join:
http://mail-archives.apache.org/mod_mbox/incubator-tinkerpop-dev/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by anagav <gi...@git.apache.org>.
Github user anagav commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149626639
@spmallette done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#discussion_r42361097
--- Diff: gremlin-server/pom.xml ---
@@ -148,6 +149,29 @@ limitations under the License.
</build>
<profiles>
<profile>
+ <id>linux</id>
+ <activation>
+ <os>
+ <family>Linux</family>
--- End diff --
Doesn't this mean that if I'm on linux, i'll always be testing epoll as the profile "activates" when the os is linux? I think we'd want the flexibility to be able to test java nio on linux, which we don't get on this approach. In other words, instead of activating by os, it should activate when requested with:
```xml
<activation>
<activeByDefault>false</activeByDefault>
<property>
<name>epoll</name>
</property>
</activation>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by anagav <gi...@git.apache.org>.
Github user anagav commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-150311041
Thanks @spmallette for merging the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by anagav <gi...@git.apache.org>.
Github user anagav commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149422676
@spmallette I have updated the code based on your comments. I will update the doc and send a different PR.
Please let me know if there are any more fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148749579
I gave this some more thought. I'm a little concerned that when we do this, tests will be bound to the OS that we're executing on. I don't imagine real problems with that, but ughhh.....if there are it's going to stink.
I wonder if we shouldn't have a configuration that forces regular java NIO even on LInux. Then in the tests we have a whole class of tests that run with that setting turned on so that if we happen to be on linux we get coverage there.
Do you have any thoughts on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149562722
Thanks for making those changes - getting into nuts and bolts now. I'm testing your changes locally. In doing so, I think you can back out your change to the gremlin-driver pom.xml that adds:
```xml
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<version>${netty.version}</version>
</dependency>
```
epoll seems to come with `netty-all` which is already present. Tests seem to work for me when I remove that extra dependency, but I thought I'd check with you first to make sure I'm not missing anything.
Please validate that everything works on your end without that change and if so, amend your PR. At that point, I will ask other committers to review and we can work toward merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by anagav <gi...@git.apache.org>.
Github user anagav commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148773801
@spmallette I have successfully run the integration test after some fixes :).
It makes sense to to have separate tests for linux and non-linux env to get coverage of using epoll event loops. Let me work on that.
Also maybe have a travis setup to run tests on multiple platforms.
Also will it be helpful to have travis build for the project? if so I can set it up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148808152
> I am still figuring it out. Do you have any suggestions?
I think we should add a configuration to manage epoll or not epoll somehow. Maybe you add something to `Settings` called `useEpollIfPossible` that is `true` or `false` (default as `false`). Then in your code, you use that setting on startup to use epoll if on linux (otherwise just use java nio) or if directly set to `false` just use java nio regardless of OS.
Now for tests, we could add an environment variable, like `GREMLIN_SERVER_EPOLL` which is `true` or `false`. in `AbstractGremlinServerIntegration` test you check for that variable (defaulted to `false`) in the `overrideSettings` method. If `true` then flip the `Setting` to `true` and return it. That will make all the tests work against Gremlin Server configured in "epoll mode".
Lastly, we add a new maven profile to the gremlin-server `pom.xml` that adds your `GREMLIN_SERVER_EPOLL` environment variable to the failsafe plugin config so that the integration tests will get that. In this way we can optionally run those tests as needed. I think it is sufficient to not constantly run those tests, but if we decide that is so, we could move it out of a profile and into a second failsafe execution.
This change would also entail an update to the documentation to describe the `epollIfPossible` setting.
What do you think? Still interested in working on it? Sad that you got sucked into this? :wink:
> I just subscribed to the mailing list.
cool - welcome. feel free to start up a thread on the CI issue. @mhfrantz and i can will join in from there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-150212985
Great @pluradj, thorough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#discussion_r42685199
--- Diff: gremlin-server/pom.xml ---
@@ -148,6 +149,30 @@ limitations under the License.
</build>
<profiles>
<profile>
+ <id>linux</id>
+ <activation>
+ <activeByDefault>false</activeByDefault>
+ <property>
+ <name>EPOLL</name>
--- End diff --
good point - i might ultimately adjust naming/docs and such once we merge. @anagav i can handle that on my end. @pluradj is that cool for you for purpose of voting?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by anagav <gi...@git.apache.org>.
Github user anagav commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-148786333
Do you have a sense of how you want to implement that?
I am still figuring it out. Do you have any suggestions?
I just subscribed to the mailing list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Use Epoll based netty eventloop ...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149672326
I reviewed the code and the code looks clean. Basically, `if(onLinux) doLinuxOptimizedSocket/Threads`. That compounded with @spmallette's expertise in this area of the code base and his review of the PR:
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---