[GitHub] [tvm] tmoreau89 commented on a change in pull request #8157: [Vulkan][Refactor] Split out vulkan.cc into separate distinct functionality

[GitBox <gi...@apache.org>]

tmoreau89 commented on a change in pull request #8157:
URL: https://github.com/apache/tvm/pull/8157#discussion_r641274980



##########
File path: src/runtime/vulkan/vulkan_stream.h
##########
@@ -43,135 +44,64 @@ struct VulkanStreamToken {
   std::vector<VkBuffer> buffers_;
 };
 
+/*!
+ *  \brief Wrapper around a vulkan command buffer
+ *
+ *  The VulkanStream collects commands into a VkCommandBuffer.  When a
+ *  newly submitted command requires resources reserved by an
+ *  already-submitted command, all of the queued commands are
+ *  submitted to the GPU, and the CPU waits for all queued commands to
+ *  finish.  The queued commands can also be explicitly pushed/waited
+ *  on by calling VulkanStream::Synchronize.
+ *
+ *  If the device is

Review comment:
       Nice work with the additional comments here, but it seems this paragraph is incomplete!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org