You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/09/12 20:24:43 UTC
Re: Review Request 25079: Replaced macro expansion with variadic
template
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25079/#review53196
-----------------------------------------------------------
Ship it!
This is awesome! I will commit shortly: I fixed a few minor style nits (removing a duplicate comment and adding newlines).
- Niklas Nielsen
On Aug. 28, 2014, 9:24 a.m., Patrick Reilly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25079/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 9:24 a.m.)
>
>
> Review request for mesos, Adam B and Benjamin Hindman.
>
>
> Bugs: MESOS-1734
> https://issues.apache.org/jira/browse/MESOS-1734
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Reduce compile time: - replacing a macro expansion with a variadic template - moving implementation from help.hpp to help.cpp
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am edbe54b
> 3rdparty/libprocess/include/process/help.hpp 4333b5b
> 3rdparty/libprocess/src/help.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25079/diff/
>
>
> Testing
> -------
>
> Ran "make check".
>
>
> Thanks,
>
> Patrick Reilly
>
>