[jira] [Commented] (CASSANDRA-3665) [patch] allow for clientutil.jar to be used without the base cassandra.jar for client applications

["Eric Evans (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193423#comment-13193423 ] 

Eric Evans commented on CASSANDRA-3665:
---------------------------------------

Where does this list of additional classes come from?  Was it tested, and if so, against which version?

I'm not sure if it's the best tool, but according to tattletale (http://www.jboss.org/tattletale), the classes we are missing are {{o.a.c.io.util.FileDataInput}}, {{o.a.c.io.util.FileUtils}}, and {{o.a.c.utils.FBUtilities}}.  That's not including transitive dependencies, (for which {{FBUtilities}} alone is a nightmare).

Even manually searching through the code I can't see where {{o.a.c.utils.ClosableIterator}} or {{o.a.c.config.ConfigurationException}} are needed.

TL;DR Let me know if I'm missing something, but it looks like this patch is adding classes which are not needed, and missing some which are.

{{FBUtilities}} is being pulled in by {{ByteBufferUtil}}, so I think the right answer there is to refactor, and move the relevant bits out, either into {{ByteBufferUtil}}, or into another class entirely.
                
> [patch] allow for clientutil.jar to be used without the base cassandra.jar for client applications
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-3665
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3665
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.0.6
>            Reporter: Dave Brosius
>            Assignee: Dave Brosius
>         Attachments: fix_client_util_jar.diff
>
>
> clientutil.jar can't be run from a client by itself without the presence of cassandra.jar which seems wrong. Added needed classes to run by itself.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira