You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@icorps.com> on 2012/07/26 20:04:03 UTC

Review Request: Fixes User (sharer) not seing declined share

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6159/
-----------------------------------------------------------

Review request for rave.


Description
-------

This fix changes the following behavior after someone declines a shared page:

1. If the sharer, were to go share the page again, the person who declined the share no longer says "Remove", it now says "Add" again.

2. If the sharer is not sharing the page to anyone else, the share icon will no longer be on the tab for that page. 


Diffs
-----

  trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541 

Diff: https://reviews.apache.org/r/6159/diff/


Testing
-------


Thanks,

Daniel Gornstein

Re: Review Request: Rave-712: Fixes User (sharer) not seing declined share

Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6159/#review9535
-----------------------------------------------------------

Ship it!


LGTM!

- Anthony Carlucci


On July 27, 2012, 11:33 a.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6159/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 11:33 a.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> This fix changes the following behavior after someone declines a shared page:
> 
> 1. If the sharer, were to go share the page again, the person who declined the share no longer says "Remove", it now says "Add" again.
> 
> 2. If the sharer is not sharing the page to anyone else, the share icon will no longer be on the tab for that page. 
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541 
> 
> Diff: https://reviews.apache.org/r/6159/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>

Re: Review Request: Rave-712: Fixes User (sharer) not seing declined share

Posted by Daniel Gornstein <dg...@icorps.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6159/
-----------------------------------------------------------

(Updated July 27, 2012, 11:33 a.m.)


Review request for rave.


Summary (updated)
-----------------

Rave-712: Fixes User (sharer) not seing declined share


Description
-------

This fix changes the following behavior after someone declines a shared page:

1. If the sharer, were to go share the page again, the person who declined the share no longer says "Remove", it now says "Add" again.

2. If the sharer is not sharing the page to anyone else, the share icon will no longer be on the tab for that page. 


Diffs
-----

  trunk/rave-portal-resources/src/main/webapp/static/script/rave_layout.js 1365541 

Diff: https://reviews.apache.org/r/6159/diff/


Testing
-------


Thanks,

Daniel Gornstein