[GitHub] [spark] MaxGekk commented on a diff in pull request #36323: [SPARK-38732][SQL][TESTS] Test the error class: INCOMPARABLE_PIVOT_COLUMN

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #36323:
URL: https://github.com/apache/spark/pull/36323#discussion_r856087230


##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -398,4 +398,32 @@ class QueryExecutionErrorsSuite
         "\\(QueryExecutionErrorsSuite\\$\\$Lambda\\$\\d+/\\w+: \\(string, int\\) => string\\)",
       matchMsg = true)
   }
+
+  test("INCOMPARABLE_PIVOT_COLUMN: Pivot columns can't be comparable") {

Review Comment:
   Maybe, the columns can't be incomparable?
   ```suggestion
     test("INCOMPARABLE_PIVOT_COLUMN: an incomparable column of the map type") {
   ```



##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -398,4 +398,32 @@ class QueryExecutionErrorsSuite
         "\\(QueryExecutionErrorsSuite\\$\\$Lambda\\$\\d+/\\w+: \\(string, int\\) => string\\)",
       matchMsg = true)
   }
+
+  test("INCOMPARABLE_PIVOT_COLUMN: Pivot columns can't be comparable") {
+    withSQLConf() {

Review Comment:
   Please, remove this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org