You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2020/06/17 09:31:54 UTC
[Bug 7828] New: uri_detail lacks support for key type "host"
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7828
Bug ID: 7828
Summary: uri_detail lacks support for key type "host"
Product: Spamassassin
Version: 3.4.4
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Plugins
Assignee: dev@spamassassin.apache.org
Reporter: wbreyha@gmx.net
Target Milestone: Undefined
I'm wondering why uri_detail doesn't support "host" as key like "domain" since
it is available in the hash returned by get_uri_detail_list().
Is this an improvement in PerMsgStatus.pm not promoted to URIDetail Plugin? A
short test with "|host" added in the list of allowed keys was successful.
------------
--- /tmp/URIDetail.pm.orig 2020-06-17 11:30:23.208951331 +0200
+++ /usr/local/share/perl5/Mail/SpamAssassin/Plugin/URIDetail.pm
2020-06-16 23:39:37.888568387 +0200
@@ -119,7 +119,7 @@
my $op = $2;
my $pattern = $3;
- if ($target !~ /^(?:raw|type|cleaned|text|domain)$/) {
+ if ($target !~ /^(?:raw|type|cleaned|text|domain|host)$/) {
return $Mail::SpamAssassin::Conf::INVALID_VALUE;
}
--------------
But I'm not sure if I missed a detail.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7828] uri_detail lacks support for key type "host"
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7828
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|PC |All
CC| |apache@hege.li
OS|Linux |All
--- Comment #1 from Henrik Krohns <ap...@hege.li> ---
(In reply to Wolfgang Breyha from comment #0)
>
> But I'm not sure if I missed a detail.
Your change allows a keyword, but there is no extra code to actually do the
matching operation itself, so it can't work.
I'll see if I can sqeeze it in today, unless someone beats me to it.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7828] uri_detail lacks support for key type "host"
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7828
Wolfgang Breyha <wb...@gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wbreyha@gmx.net
--- Comment #2 from Wolfgang Breyha <wb...@gmx.net> ---
Created attachment 5703
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5703&action=edit
add "host" key
oh, sorry, yes. I didn't check the negative case. My test rule simply triggered
every time. I added the matching code now and tested both positive and negative
case.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7828] uri_detail lacks support for key type "host"
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7828
Henrik Krohns <ap...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #3 from Henrik Krohns <ap...@hege.li> ---
Fixed
Sending spamassassin-3.4/UPGRADE
Sending spamassassin-3.4/lib/Mail/SpamAssassin/Plugin/URIDetail.pm
Sending trunk/lib/Mail/SpamAssassin/Plugin/URIDetail.pm
Transmitting file data ...done
Committing transaction...
Committed revision 1878990.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7828] uri_detail lacks support for key type "host"
Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7828
--- Comment #4 from Henrik Krohns <ap...@hege.li> ---
PS. For global use, should be enclosed with
if can(Mail::SpamAssassin::Plugin::URIDetail::has_host_key)
endif
--
You are receiving this mail because:
You are the assignee for the bug.