You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org> on 2010/04/25 23:19:49 UTC
[jira] Created: (MYFACES-2675) BeanValidation does not work with
composite components
BeanValidation does not work with composite components
------------------------------------------------------
Key: MYFACES-2675
URL: https://issues.apache.org/jira/browse/MYFACES-2675
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.0
Reporter: Jakob Korherr
Assignee: Jakob Korherr
The code committed in MYFACES-2633 causes Bean-Validation to stop working on composite components, because the BeanValidator can't access the actual ValueExpression anymore, because it is not on the component's attribute map.
In MYFACES-2622 I committed code that handled CompositeComponentExpressionHolder correctly on the BeanValidator. After this commit BeanValidation worked well for composite components. Last week I stumbled upon this again and noticed it was not working anymore. As mentioned before, the code committed in MYFACES-2633 causes this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2675) BeanValidation does not work with
composite components
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr resolved MYFACES-2675.
------------------------------------
Fix Version/s: 2.0.1-SNAPSHOT
Resolution: Fixed
> BeanValidation does not work with composite components
> ------------------------------------------------------
>
> Key: MYFACES-2675
> URL: https://issues.apache.org/jira/browse/MYFACES-2675
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.1-SNAPSHOT
>
> Attachments: MYFACES-2675-test.patch
>
>
> The code committed in MYFACES-2633 causes Bean-Validation to stop working on composite components, because the BeanValidator can't access the actual ValueExpression anymore, because it is not on the component's attribute map.
> In MYFACES-2622 I committed code that handled CompositeComponentExpressionHolder correctly on the BeanValidator. After this commit BeanValidation worked well for composite components. Last week I stumbled upon this again and noticed it was not working anymore. As mentioned before, the code committed in MYFACES-2633 causes this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2675) BeanValidation does not work with
composite components
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860765#action_12860765 ]
Jakob Korherr commented on MYFACES-2675:
----------------------------------------
If you revert the changes from MYFACES-2633, everything works fine here again. However we have to find a solution that solves all three issues.
> BeanValidation does not work with composite components
> ------------------------------------------------------
>
> Key: MYFACES-2675
> URL: https://issues.apache.org/jira/browse/MYFACES-2675
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
>
> The code committed in MYFACES-2633 causes Bean-Validation to stop working on composite components, because the BeanValidator can't access the actual ValueExpression anymore, because it is not on the component's attribute map.
> In MYFACES-2622 I committed code that handled CompositeComponentExpressionHolder correctly on the BeanValidator. After this commit BeanValidation worked well for composite components. Last week I stumbled upon this again and noticed it was not working anymore. As mentioned before, the code committed in MYFACES-2633 causes this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2675) BeanValidation does not work with
composite components
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860991#action_12860991 ]
Jakob Korherr commented on MYFACES-2675:
----------------------------------------
After a lot of debugging, I found out that the code committed in MYFACES-2633 really is correct.
The problem with bean validation occured because CompositeComponentAttributesMapWrapper had to be adapted to work with the changes from MYFACES-2633.
> BeanValidation does not work with composite components
> ------------------------------------------------------
>
> Key: MYFACES-2675
> URL: https://issues.apache.org/jira/browse/MYFACES-2675
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0
> Reporter: Jakob Korherr
> Assignee: Jakob Korherr
> Fix For: 2.0.1-SNAPSHOT
>
> Attachments: MYFACES-2675-test.patch
>
>
> The code committed in MYFACES-2633 causes Bean-Validation to stop working on composite components, because the BeanValidator can't access the actual ValueExpression anymore, because it is not on the component's attribute map.
> In MYFACES-2622 I committed code that handled CompositeComponentExpressionHolder correctly on the BeanValidator. After this commit BeanValidation worked well for composite components. Last week I stumbled upon this again and noticed it was not working anymore. As mentioned before, the code committed in MYFACES-2633 causes this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.